-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 🎸 [HCPSDKFIORIUIKIT-2896]Card Insert Custom Component #998
feat: 🎸 [HCPSDKFIORIUIKIT-2896]Card Insert Custom Component #998
Conversation
added some new examples
.padding() | ||
.cardStyle(.card) | ||
} header: { | ||
Text("custom elements for KIP Component") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Text("custom elements for KIP Component") | |
Text("custom elements for KPI Component - kpiCaption") |
.foregroundStyle(Color(hex: "#AA0808")) | ||
.font(.subheadline) | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove empty line
.padding(.leading, 20) | ||
.fontWeight(.bold) | ||
}.padding(.bottom, 10) | ||
Section { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a empty line above line 157
.padding(.leading, 20) | ||
.fontWeight(.bold) | ||
}.padding(.bottom, 10) | ||
Section { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add empty line above line 92
.padding() | ||
.cardStyle(.card) | ||
} header: { | ||
Text("custom elements for Tag Component") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this is for Tag Component? Did not see "tag" is used in the example code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spec says:
The right accessory with button and counter should be changed to 2 flexible containers, where any custom component can be placed in.
So, we need add a sample case, to both of the button and counter area can be customized, and show up at the same time.
fixed |
added some new examples