Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 [HCPSDKFIORIUIKIT-2896]Card Insert Custom Component #998

Merged

Conversation

KevinZK
Copy link
Collaborator

@KevinZK KevinZK commented Feb 27, 2025

added some new examples

@KevinZK KevinZK requested a review from a team as a code owner February 27, 2025 06:32
@KevinZK KevinZK requested review from billzhou0223 and removed request for a team February 27, 2025 06:32
.padding()
.cardStyle(.card)
} header: {
Text("custom elements for KIP Component")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Text("custom elements for KIP Component")
Text("custom elements for KPI Component - kpiCaption")

.foregroundStyle(Color(hex: "#AA0808"))
.font(.subheadline)
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove empty line

.padding(.leading, 20)
.fontWeight(.bold)
}.padding(.bottom, 10)
Section {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a empty line above line 157

.padding(.leading, 20)
.fontWeight(.bold)
}.padding(.bottom, 10)
Section {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add empty line above line 92

.padding()
.cardStyle(.card)
} header: {
Text("custom elements for Tag Component")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this is for Tag Component? Did not see "tag" is used in the example code.

Copy link
Contributor

@dyongxu dyongxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spec says:
The right accessory with button and counter should be changed to 2 flexible containers, where any custom component can be placed in.

So, we need add a sample case, to both of the button and counter area can be customized, and show up at the same time.

@KevinZK
Copy link
Collaborator Author

KevinZK commented Feb 28, 2025

The spec says: The right accessory with button and counter should be changed to 2 flexible containers, where any custom component can be placed in.

So, we need add a sample case, to both of the button and counter area can be customized, and show up at the same time.

fixed

@dyongxu dyongxu merged commit c6c5174 into SAP:main Mar 1, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants