Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): make popover body have dialog role by default #12908

Merged
merged 3 commits into from
Jan 9, 2025
Merged

fix(core): make popover body have dialog role by default #12908

merged 3 commits into from
Jan 9, 2025

Conversation

mikerodonnell89
Copy link
Member

fixes #12716

@mikerodonnell89 mikerodonnell89 requested a review from a team January 6, 2025 18:38
@mikerodonnell89 mikerodonnell89 self-assigned this Jan 6, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 6, 2025 •
edited
Loading

❌ Check the deploy log for errors here: https://app.netlify.com/sites/fundamental-ngx/deploys

Name Link
🔨 Latest commit 85b8900
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/677ff7529f74d90008dad5d1

@mikerodonnell89 mikerodonnell89 merged commit be56ee2 into ng-15-downport Jan 9, 2025
14 of 19 checks passed
@mikerodonnell89 mikerodonnell89 deleted the fix/12716-ng15 branch January 9, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@InnaAtanasova InnaAtanasova InnaAtanasova approved these changes

Assignees

@mikerodonnell89 mikerodonnell89

Labels
None yet
Projects
None yet
Milestone
Sprint 141 - December 2024
Development

Successfully merging this pull request may close these issues.
2 participants
@mikerodonnell89 @InnaAtanasova