feat(core): created a new legend section #12915
Conversation
alexhristov14
requested review from
mikerodonnell89,
droshev and
InnaAtanasova
❌ Check the deploy log for errors here: https://app.netlify.com/sites/fundamental-ngx/deploys
|
|
Visit the preview URL for this PR (updated for commit 44ca71c): https://fundamental-ngx-gh--pr12915-feat-calendar-legend-qfybq5e1.web.app (expires Mon, 27 Jan 2025 18:46:21 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff |
There was a problem hiding this comment.
This is looking good, but I left a few comments on things to consider. Also this PR seems to just add this to calendar, I think to consider the original issue completed, we'll need to add this to datepicker/datetimepicker as well. Though I would be in favor of considering that a separate task, I prefer several small pr's over one large one when possible.
| @@ -58,7 +58,7 @@ | |||
| "fast-deep-equal": "3.1.3", | |||
| "focus-trap": "7.1.0", | |||
| "focus-visible": "5.2.1", | |||
| "fundamental-styles": "0.38.0", | |||
| "fundamental-styles": "0.39.0-rc.22", | |||
There was a problem hiding this comment.
need to release a new fundamental-styles version and update here before merging this pr
libs/docs/core/calendar/examples/calendar-legend-example/calendar-legend-example.component.scss
Outdated
Show resolved
Hide resolved
|
|
||
| /** @hidden */ | ||
| ngOnInit(): void { | ||
| this._addCalendarLegend(); |
There was a problem hiding this comment.
This logic being placed in the init lifecycle method will lead to problems if the special days are updated after the calendar is created. You could watch for changes to the specialDaysRules. But I think a better way of handling this would be to avoid typescript-side logic wherever possible, instead opting to render as much as possible with double curly brace interpolation in calendar.component.html
alexhristov14
force-pushed
the
feat/calendar-legend
branch
from
35a8baf to
ee41fa9
Compare
added a few inputs to legend item minor classes changes used BuildClass can insert a legend programatically with SpecialDays made programmable through SpecialDayRules adding a focusing service to filter legend days modified the calendar legend docs connected the legend to days, can be logged remove unfocused classes calendar cells focus/unfocus dynamically legends are only focusing on their own calendar and not others some written tests calendar legend test passing finished the tests for legend item finished last test and made couple changes to docs added path to index.ts
alexhristov14
force-pushed
the
feat/calendar-legend
branch
from
ee41fa9 to
44ca71c
Compare
closes #12403