Remove old todos #3851
Merged
Remove old todos #3851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndricimrr
added
the
refactoring
ndricimrr
commented
Aug 9, 2024
| @@ -127,7 +127,7 @@ | |||
| compound: compoundConfig, | |||
| viewUrl: viewurl, | |||
| webcomponent: GenericHelperFunctions.checkWebcomponentValue(webcomponent) || true | |||
| }; // TODO: fill with sth | |||
| }, | ||
| '*' | ||
| ); | ||
| break; | ||
| case LuigiInternalMessageID.NAVIGATION_REQUEST: | ||
| this.dispatch(Events.NAVIGATION_REQUEST, targetCnt, event.data.params); | ||
| break; | ||
| // TODO 1: handle alerts with ids on next iteration |
| @@ -164,7 +163,6 @@ export class ContainerService { | |||
| case LuigiInternalMessageID.GET_CURRENT_ROUTE_REQUEST: | |||
| this.dispatch(Events.GET_CURRENT_ROUTE_REQUEST, targetCnt, event); | |||
| break; | |||
| // TODO: discuss if actually needed as the only scenario is when microfrontend initially starts | |||
There was a problem hiding this comment.
needed as it needs to fit to existing LuigiClient
| @@ -746,7 +746,6 @@ | |||
| msg: 'luigi.ux.alert.hide', | |||
| id, | |||
| dismissKey | |||
| //TODO: update docu for this param | |||
There was a problem hiding this comment.
outdated from long time ago
ndricimrr
requested review from
hardl,
JohannesDoberer,
VincentUllal,
smahati,
walmazacn and
amilewskaa
as code owners
ndricimrr
commented
Aug 9, 2024
| @@ -364,7 +364,7 @@ export class WebComponentService { | |||
|
|
|||
| if (wc.__postProcess) { | |||
| const url = | |||
| new URL(document.baseURI).origin === new URL(viewUrl, document.baseURI).origin // TODO: check if needed | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
part of #3532