clarify the difference between attributes and properties #3856
Conversation
smahati
requested review from
hardl,
JohannesDoberer,
ndricimrr,
VincentUllal,
walmazacn and
amilewskaa
as code owners
|
not sure if this is supposed to be in the source code somewhere. |
|
Added snippets for the compound container, if this looks ok I can add snippets to the other API reference as well. |
docs/luigi-compound-container-api.md
Outdated
| ``` | ||
|
|
||
| ```HTML | ||
| <luigi-container viewUrl="/index.html" compoundConfig='{foo: bar}'></luigi-container> |
There was a problem hiding this comment.
Not sure if we should provide an example for compould attribute in html
There was a problem hiding this comment.
given the size of it, it seems reasonable to not wanting people to do it this way so I removed it
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
|
After the changes please run |
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
|
@JohannesDoberer I added the examples to both files and generated the docs, I can clean it up a bit more but it's ready to be reviewed. |
| @@ -1 +1 @@ | |||
| 18 | |||
There was a problem hiding this comment.
Why did you add this and removed the 18?
There was a problem hiding this comment.
I use nvm and it was causing issues as my v18's minor version was not meeting the minimum requirement. However lts/hydrogen is also v18 but updated to the latest version so I changed it to make it easier but can revert if needed and I can probably update my v18 to the latest version too.
Description
Changes proposed in this pull request:
Related issue(s)
Fixed #3848