Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changelog container #3862

Merged
merged 11 commits into from
Aug 27, 2024
Merged

Changelog container #3862

merged 11 commits into from
Aug 27, 2024

Conversation

JohannesDoberer
Copy link
Contributor

Make sure releasemeister docu is updated

@JohannesDoberer
Copy link
Contributor Author

lerna-changelog does not work. It does not support to run for a specific lib within a repo.
In addition lerna-changelog seems to be not actively maintained.
Decided to introduce a release-cli for container which updates the package.json and change the changelog.md file with the new changes.
Releasemeister docu is also updated.

@JohannesDoberer JohannesDoberer mentioned this pull request Aug 22, 2024
Open
@JohannesDoberer JohannesDoberer marked this pull request as ready for review August 22, 2024 13:18
@JohannesDoberer
Copy link
Contributor Author

UI5 support lib will be handled in a different issue #3867

@ndricimrr ndricimrr self-assigned this Aug 22, 2024
ndricimrr
ndricimrr reviewed Aug 22, 2024
View reviewed changes
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comments

container/CHANGELOG.md Show resolved Hide resolved
container/CHANGELOG.md Show resolved Hide resolved
container/release-cli.js Show resolved Hide resolved
container/release-cli.js Show resolved Hide resolved
ndricimrr
ndricimrr approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working well 👍

@JohannesDoberer JohannesDoberer merged commit e9c658a into main Aug 27, 2024
11 checks passed
@JohannesDoberer JohannesDoberer deleted the changelog-container branch August 27, 2024 05:53
@JohannesDoberer JohannesDoberer added internal Stuff like NFRs, CI pipeline container labels Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndricimrr ndricimrr ndricimrr approved these changes

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@VincentUllal VincentUllal Awaiting requested review from VincentUllal VincentUllal is a code owner

@smahati smahati Awaiting requested review from smahati smahati is a code owner

@walmazacn walmazacn Awaiting requested review from walmazacn walmazacn is a code owner

@amilewskaa amilewskaa Awaiting requested review from amilewskaa amilewskaa is a code owner

Assignees

@ndricimrr ndricimrr

Labels
container internal Stuff like NFRs, CI pipeline
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohannesDoberer @ndricimrr