Improves jsdocs for events #4019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohannesDoberer
requested review from
hardl,
ndricimrr,
VincentUllal,
smahati,
walmazacn and
amilewskaa
as code owners
walmazacn
reviewed
Nov 7, 2024
walmazacn
reviewed
Nov 7, 2024
walmazacn
reviewed
Nov 7, 2024
walmazacn
reviewed
Nov 7, 2024
walmazacn
reviewed
Nov 7, 2024
walmazacn
reviewed
Nov 7, 2024
walmazacn
reviewed
Nov 7, 2024
walmazacn
reviewed
Nov 7, 2024
walmazacn
requested changes
Nov 7, 2024
|
omg! Thx 👍 |
smahati
reviewed
Nov 7, 2024
| */ | ||
| export const GET_CURRENT_ROUTE_REQUEST = 'get-current-route-request'; | ||
|
|
||
| /** | ||
| * A message emitted from the micro frontend to report that the navigation is completed is sent | ||
| * Event fired when the micro frontend requests to report that the navigation is completed. |
There was a problem hiding this comment.
Suggested change
| * Event fired when the micro frontend requests to report that the navigation is completed. | |
| * Event fired to report that the micro frontend's navigation has completed. |
| */ | ||
| export const UPDATE_MODAL_PATH_DATA_REQUEST = 'update-modal-path-data-request'; | ||
|
|
||
| /** | ||
| * A message emitted from the micro frontend when a request to check on the validity of a path is sent | ||
| * Event fired when the micro frontend requests to check on the validity of a path. |
There was a problem hiding this comment.
Suggested change
| * Event fired when the micro frontend requests to check on the validity of a path. | |
| * Event fired to report that the micro frontend's navigation has completed. |
| */ | ||
| export const CHECK_PATH_EXISTS_REQUEST = 'check-path-exists-request'; | ||
|
|
||
| /** | ||
| * A message emitted from the micro frontend when a request to set the 'dirty status' (eg: avoid closing if unsaved changes) is sent | ||
| * Event fired when the micro frontend requests to set the 'dirty status' (e.g. avoid closing if unsaved changes). |
There was a problem hiding this comment.
Suggested change
| * Event fired when the micro frontend requests to set the 'dirty status' (e.g. avoid closing if unsaved changes). | |
| * Event fired when the micro frontend requests to set the 'dirty status' which, for example, avoids closing when there are any unsaved changes. |
Co-authored-by: Mahati Shankar <[email protected]>
Co-authored-by: Mahati Shankar <[email protected]>
Co-authored-by: Mahati Shankar <[email protected]>
Co-authored-by: Mahati Shankar <[email protected]>
Co-authored-by: Mahati Shankar <[email protected]>
Co-authored-by: Mahati Shankar <[email protected]>
Co-authored-by: Mahati Shankar <[email protected]>
Co-authored-by: Mahati Shankar <[email protected]>
Co-authored-by: Mahati Shankar <[email protected]>
Co-authored-by: Mahati Shankar <[email protected]>
Co-authored-by: Mahati Shankar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.