Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG - handling of undefined response from sap/ui/VersionInfo.load #2207

Closed
heimwege opened this issue Jul 31, 2024 · 1 comment
Closed

BUG - handling of undefined response from sap/ui/VersionInfo.load #2207

heimwege opened this issue Jul 31, 2024 · 1 comment
Assignees
Labels
bug Something isn't working preview-middleware-client

Comments

@heimwege
Copy link
Contributor

heimwege commented Jul 31, 2024

Description

As described in #2192 (comment) the handling of undefined response from sap/ui/VersionInfo.load should be fixed.

  1. Add | undefined at the end of SingleVersionInfo type
  2. Fix errors reported by tsc --noEmit

Root Cause Analysis

Problem

{describe the problem}

Fix

{describe the fix}

Why was it missed

{Some explanation why this issue might have been missed during normal development/testing cycle}

How can we avoid this

{if we don’t want to see this type of issues anymore what we should do to prevent}

@heimwege
Copy link
Contributor Author

heimwege commented Aug 5, 2024

Fixed in #2208

@heimwege heimwege closed this as completed Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working preview-middleware-client
Projects
None yet
Development

No branches or pull requests

1 participant