Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview support for UI5 2.x #2192

Merged
merged 22 commits into from
Jul 31, 2024
Merged

Preview support for UI5 2.x #2192

merged 22 commits into from
Jul 31, 2024

Conversation

schreckstefan
Copy link
Contributor

@schreckstefan schreckstefan commented Jul 25, 2024

Issue: #1679

For supporting UI5 2.x, the different ushell sandbox src now gets dynamically set by a script.
Further things that had to be changed:

  • sap.ui.version does not exist anymore, use VersionInfo.load() instead
  • sandbox2.js obviously does not have a function createRenderer, but only createRendererInternal that needs to be called.

For testing, I had to set the right target url at the yaml file of the test app:

  • name: preview-middleware
    afterMiddleware: compression
    configuration:
    ui5:
    - path: /resources
    - path: /test-resources
    url: https://sapui5...

@schreckstefan schreckstefan requested a review from a team as a code owner July 25, 2024 13:49
Copy link

changeset-bot bot commented Jul 25, 2024

🦋 Changeset detected

Latest commit: b2209e5

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@schreckstefan schreckstefan marked this pull request as draft July 25, 2024 13:50
Copy link
Contributor

@heimwege heimwege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some smaller finding

packages/preview-middleware-client/src/flp/bootstrap.ts Outdated Show resolved Hide resolved
packages/preview-middleware-client/src/flp/init.ts Outdated Show resolved Hide resolved
packages/preview-middleware-client/src/flp/init.ts Outdated Show resolved Hide resolved
@schreckstefan schreckstefan mentioned this pull request Jul 26, 2024
@schreckstefan schreckstefan changed the title Preview 2.0 (2nd try) Preview support for UI5 2.x Jul 26, 2024
@schreckstefan schreckstefan marked this pull request as ready for review July 26, 2024 10:07
@heimwege
Copy link
Contributor

Cross link to SAP/openui5#4105 for a better type description for sap-ui-version.json. Once it is done this one can be deleted.

Copy link
Contributor

@tobiasqueck tobiasqueck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • changeset ok
  • code adheres to coding standards
  • successfully tested with CDN 1.x/2.0 and local 1.x

Copy link

Copy link
Contributor

@Klaus-Keller Klaus-Keller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks,

  • code to address UI5 2.x differences looks good
  • changeset exists
  • code coverage is good
  • did a local test and it works

@Klaus-Keller Klaus-Keller merged commit ab2e5a0 into main Jul 31, 2024
13 checks passed
@Klaus-Keller Klaus-Keller deleted the feat/1679/preview20 branch July 31, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants