-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preview support for UI5 2.x #2192
Conversation
🦋 Changeset detectedLatest commit: b2209e5 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some smaller finding
packages/preview-middleware-client/src/cpe/connector-service.ts
Outdated
Show resolved
Hide resolved
Cross link to SAP/openui5#4105 for a better type description for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- changeset ok
- code adheres to coding standards
- successfully tested with CDN 1.x/2.0 and local 1.x
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks,
- code to address UI5 2.x differences looks good
- changeset exists
- code coverage is good
- did a local test and it works
Issue: #1679
For supporting UI5 2.x, the different ushell sandbox src now gets dynamically set by a script.
Further things that had to be changed:
createRenderer
, but onlycreateRendererInternal
that needs to be called.For testing, I had to set the right target url at the yaml file of the test app: