fix: Eslint issues

SAP · Jul 12, 2024 · 1a979d3 · 1a979d3
1 parent e333be1
commit 1a979d3
Show file tree

Hide file tree

Showing 6 changed files with 17 additions and 17 deletions.
diff --git a/src/linter/html/parser.ts b/src/linter/html/parser.ts
@@ -17,11 +17,11 @@ export async function extractJSScriptTags(contentStream: ReadStream) {
 				// https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script/type#attribute_is_not_set_default_an_empty_string_or_a_javascript_mime_type
 				return attr.name.value !== "type" ||
 					(attr.name.value === "type" &&
-					["",
-						"module",
-						"text/javascript",
-						"application/javascript", /* legacy */
-					].includes(attr.value.value.toLowerCase()));
+						["",
+							"module",
+							"text/javascript",
+							"application/javascript", /* legacy */
+						].includes(attr.value.value.toLowerCase()));
 			});
 
 			if (isJSScriptTag) {

diff --git a/src/linter/ui5Types/SourceFileLinter.ts b/src/linter/ui5Types/SourceFileLinter.ts
@@ -72,7 +72,7 @@ export default class SourceFileLinter {
 			this.analyzeCallExpression(node as ts.CallExpression); // Check for deprecation
 			this.analyzeLibInitCall(node as ts.CallExpression); // Check for sap/ui/core/Lib.init usages
 		} else if (node.kind === ts.SyntaxKind.PropertyAccessExpression ||
-		node.kind === ts.SyntaxKind.ElementAccessExpression) {
+			node.kind === ts.SyntaxKind.ElementAccessExpression) {
 			this.analyzePropertyAccessExpression(
 				node as (ts.PropertyAccessExpression | ts.ElementAccessExpression)); // Check for global
 			this.analyzePropertyAccessExpressionForDeprecation(
@@ -304,7 +304,7 @@ export default class SourceFileLinter {
 			if (!apiVersionNode) { // No arguments or no 'apiVersion' property
 				nodeToHighlight = node;
 			} else if (ts.isPropertyAssignment(apiVersionNode) &&
-			apiVersionNode.initializer.getText() !== "2") { // String value would be "\"2\""
+				apiVersionNode.initializer.getText() !== "2") { // String value would be "\"2\""
 				nodeToHighlight = apiVersionNode;
 			}
 		}

diff --git a/src/linter/ui5Types/amdTranspiler/moduleDeclarationToDefinition.ts b/src/linter/ui5Types/amdTranspiler/moduleDeclarationToDefinition.ts
@@ -197,7 +197,7 @@ function getModuleBody(
 							// 	node.expression));
 						}
 					} else if (ts.isExpressionStatement(node) && ts.isStringLiteral(node.expression) &&
-					node.expression.text === "use strict") {
+						node.expression.text === "use strict") {
 						// Ignore "use strict" directive
 						continue;
 					} else {
@@ -229,10 +229,10 @@ function getModuleBody(
 			body = [createDefaultExport(nodeFactory, moduleDeclaration.factory.body)];
 		}
 	} else if (ts.isClassDeclaration(moduleDeclaration.factory) ||
-	ts.isLiteralExpression(moduleDeclaration.factory) ||
-	ts.isArrayLiteralExpression(moduleDeclaration.factory) ||
-	ts.isObjectLiteralExpression(moduleDeclaration.factory) ||
-	ts.isPropertyAccessExpression(moduleDeclaration.factory)) {
+		ts.isLiteralExpression(moduleDeclaration.factory) ||
+		ts.isArrayLiteralExpression(moduleDeclaration.factory) ||
+		ts.isObjectLiteralExpression(moduleDeclaration.factory) ||
+		ts.isPropertyAccessExpression(moduleDeclaration.factory)) {
 		// Use factory directly
 		body = [createDefaultExport(nodeFactory, moduleDeclaration.factory)];
 	} else { // Identifier

diff --git a/src/linter/ui5Types/amdTranspiler/rewriteExtendCall.ts b/src/linter/ui5Types/amdTranspiler/rewriteExtendCall.ts
@@ -75,7 +75,7 @@ function getClassBodyFromArguments(
 					undefined,
 					prop.initializer.body);
 			} else if (ts.isObjectLiteralExpression(prop.initializer) &&
-			ts.isIdentifier(prop.name) && prop.name.text === "metadata") {
+				ts.isIdentifier(prop.name) && prop.name.text === "metadata") {
 				// Transform to *static* property declaration?
 				// This would align it with how UI5 projects should declare metadata in TypeScript,
 				// however it's unclear whether this helps our static analysis

diff --git a/src/linter/ui5Types/asyncComponentFlags.ts b/src/linter/ui5Types/asyncComponentFlags.ts
@@ -266,8 +266,8 @@ function doPropsCheck(metadata: ts.PropertyDeclaration, manifestContent: string
 		}
 
 		hasManifestDefinition = !!(componentManifest &&
-		ts.isPropertyAssignment(componentManifest) &&
-		componentManifest.initializer.getText() === "\"json\"");
+			ts.isPropertyAssignment(componentManifest) &&
+			componentManifest.initializer.getText() === "\"json\"");
 	}
 
 	return {

diff --git a/src/linter/xmlTemplate/Parser.ts b/src/linter/xmlTemplate/Parser.ts
@@ -428,7 +428,7 @@ export default class Parser {
 
 					this.#generator.writeRequire(requireExpression);
 				} else if (resolvedNamespace === FESR_NAMESPACE ||
-				resolvedNamespace === SAP_BUILD_NAMESPACE || resolvedNamespace === SAP_UI_DT_NAMESPACE) {
+					resolvedNamespace === SAP_BUILD_NAMESPACE || resolvedNamespace === SAP_UI_DT_NAMESPACE) {
 					// Silently ignore FESR, sap.build and sap.ui.dt attributes
 				} else if (resolvedNamespace === CUSTOM_DATA_NAMESPACE) {
 					// Add custom data element and add it as an aggregation
@@ -515,7 +515,7 @@ export default class Parser {
 			}
 			return ownerAggregation;
 		} else if (this.#xmlDocumentKind === DocumentKind.Fragment && moduleName === "FragmentDefinition" &&
-		namespace === CORE_NAMESPACE) {
+			namespace === CORE_NAMESPACE) {
 			// This node declares a fragment definition
 			const node: FragmentDefinitionDeclaration = {
 				kind: NodeKind.FragmentDefinition,