refactor: Cleanups

SAP · Dec 6, 2024 · 3f574fc · 3f574fc
1 parent 86a88d8
commit 3f574fc
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/src/linter/html/transpiler.ts b/src/linter/html/transpiler.ts
@@ -134,14 +134,14 @@ function lintBootstrapAttributes(tag: Tag, report: HtmlReporter) {
 				checkPreloadAttr(attr, report);
 				break;
 			case "data-sap-ui-no-duplicate-ids":
+			case "data-sap-ui-auto-aria-body-role":
 				report.addMessage(MESSAGE.REDUNDANT_BOOTSTRAP_PARAM_ERROR, {
 					name: attr.name.value,
 				}, attr.name);
 				break;
 			case "data-sap-ui-xx-no-less":
 			case "data-sap-ui-areas":
 			case "data-sap-ui-trace":
-			case "data-sap-ui-auto-aria-body-role":
 				report.addMessage(MESSAGE.ABANDONED_BOOTSTRAP_PARAM, {
 					name: attr.name.value,
 				}, attr.name);

diff --git a/src/linter/messages.ts b/src/linter/messages.ts
@@ -70,7 +70,7 @@ export const MESSAGE_INFO = {
 
 		message: ({name}: {name: string}) =>
 			`Abandoned bootstrap parameter '${name}' should be removed`,
-		details: ({message}: {message?: string}) => message,
+		details: () => undefined,
 	},
 
 	[MESSAGE.COMPONENT_MISSING_ASYNC_INTERFACE]: {
@@ -421,7 +421,7 @@ export const MESSAGE_INFO = {
 
 		message: ({name}: {name: string}) =>
 			`Redundant bootstrap parameter '${name}' should be removed`,
-		details: ({messageDetails}: {messageDetails?: string}) => messageDetails,
+		details: () => undefined,
 	},
 
 	[MESSAGE.REDUNDANT_BOOTSTRAP_PARAM_ERROR]: {

diff --git a/test/lib/linter/rules/snapshots/NoDeprecatedApi.ts.md b/test/lib/linter/rules/snapshots/NoDeprecatedApi.ts.md
@@ -11,7 +11,7 @@ Generated by [AVA](https://avajs.dev).
     [
       {
         coverageInfo: [],
-        errorCount: 12,
+        errorCount: 13,
         fatalErrorCount: 0,
         filePath: 'BootstrapParameters_Deprecations.html',
         messages: [
@@ -71,9 +71,9 @@ Generated by [AVA](https://avajs.dev).
           {
             column: 3,
             line: 18,
-            message: 'Abandoned bootstrap parameter \'data-sap-ui-auto-aria-body-role\' should be removed',
+            message: 'Redundant bootstrap parameter \'data-sap-ui-auto-aria-body-role\' should be removed',
             ruleId: 'no-deprecated-api',
-            severity: 1,
+            severity: 2,
           },
           {
             column: 3,
@@ -177,7 +177,7 @@ Generated by [AVA](https://avajs.dev).
             severity: 1,
           },
         ],
-        warningCount: 10,
+        warningCount: 9,
       },
     ]
 

diff --git a/test/lib/linter/rules/snapshots/NoDeprecatedApi.ts.snap b/test/lib/linter/rules/snapshots/NoDeprecatedApi.ts.snap