Skip to content

Commit

Permalink
revert: Remove workaround for deprecation text
Browse files Browse the repository at this point in the history
This reverts commit c8de9c4.

Not all libraries have been updated yet as new SAPUI5 patch releases
do not include new versions of every library.

See #29
  • Loading branch information
matz3 committed Mar 18, 2024
1 parent 8b19da4 commit 8e56d45
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/detectors/typeChecker/FileLinter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,11 @@ export default class FileLinter {
}

getDeprecationText(deprecatedTag: ts.JSDocTagInfo): string {
return deprecatedTag.text?.reduce((acc, text) => acc + text.text, "") ?? "";
// (Workaround) There's an issue in some UI5 TS definition versions and where the
// deprecation text gets merged with the description. Splitting on double
// new line could be considered as a clear separation between them.
// https://github.com/SAP/ui5-typescript/issues/429
return deprecatedTag.text?.reduce((acc, text) => acc + text.text, "").split("\n\n")[0] ?? "";
}

getDeprecationInfo(symbol: ts.Symbol | undefined): DeprecationInfo | null {
Expand Down

0 comments on commit 8e56d45

Please sign in to comment.