fix: Respect any character within script tags

SAP · Apr 10, 2024 · af459f2 · af459f2
1 parent d042458
commit af459f2
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 2 deletions.
diff --git a/src/linter/html/linter.ts b/src/linter/html/linter.ts
@@ -12,7 +12,7 @@ export async function lintHtml(resourceName: string, contentStream: ReadStream):
 	const jsScriptTags = await extractJSScriptTags(contentStream);
 
 	jsScriptTags.forEach((tag) => {
-		const scriptContent = tag.textNodes?.map((tNode) => tNode.value).join("").trim();
+		const scriptContent = tag.textNodes?.map((tNode) => tNode.value).join("");
 		// Tags with src attribute do not parse and run inline code
 		const hasSrc = tag.attributes.some((attr) => {
 			return attr.name.value.toLowerCase() === "src";

diff --git a/test/fixtures/linter/rules/CSPCompliance/NoInlineJS.html b/test/fixtures/linter/rules/CSPCompliance/NoInlineJS.html
@@ -51,6 +51,10 @@
 
 		export const names = ["Kayla", "Bentley", "Gilligan"];
 	</script>
+
+	<script>
+		// This one should be reported!
+	</script>
 </body>
 
 </html>
diff --git a/test/lib/linter/rules/snapshots/CSPCompliance.ts.md b/test/lib/linter/rules/snapshots/CSPCompliance.ts.md
@@ -60,8 +60,17 @@ Generated by [AVA](https://avajs.dev).
             ruleId: 'ui5-linter-csp-unsafe-inline-script',
             severity: 1,
           },
+          {
+            column: 2,
+            fatal: undefined,
+            line: 55,
+            message: 'Use of unsafe inline script',
+            messageDetails: 'Content Security Policy (https://ui5.sap.com/1.120/#/topic/fe1a6dba940e479fb7c3bc753f92b28c)',
+            ruleId: 'ui5-linter-csp-unsafe-inline-script',
+            severity: 1,
+          },
         ],
-        warningCount: 5,
+        warningCount: 6,
       },
     ]
 

diff --git a/test/lib/linter/rules/snapshots/CSPCompliance.ts.snap b/test/lib/linter/rules/snapshots/CSPCompliance.ts.snap