Skip to content

Commit

Permalink
fix: Update list of deprecated libs (#42)
Browse files Browse the repository at this point in the history 
- Sort entries
- Remove non-existent sap.dragonfly
- Fix typo for sap.landvisz
- Add missing sap.sac.grid
- Add removed internal sap.fe libs

Co-authored-by: Max Reichmann <[email protected]>
  • Loading branch information
@matz3 @maxreichmann
matz3 and maxreichmann authored Mar 22, 2024
1 parent d313912 commit d38e356
Show file tree
Hide file tree
Showing 4 changed files with 55 additions and 25 deletions.
9 changes: 6 additions & 3 deletions src/linter/json/ManifestLinter.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,19 +20,22 @@ interface locType {
const deprecatedLibraries: string[] = [
"sap.ca.scfld.md",
"sap.ca.ui",
"sap.dragonfly",
"sap.landviz",
"sap.fe.common", // Internal, removed in 1.110
"sap.fe.plugins", // Internal, removed in 1.102
"sap.fe.semantics", // Internal, removed in 1.104
"sap.landvisz", // Removed in 1.120
"sap.makit",
"sap.me",
"sap.sac.grid", // Removed in 1.114
"sap.ui.commons",
"sap.ui.suite",
"sap.ui.ux3",
"sap.ui.vtm",
"sap.uiext.inbox",
"sap.webanalytics.core",
"sap.zen.dsh",
"sap.zen.commons",
"sap.zen.crosstab",
"sap.zen.dsh",
];

const deprecatedComponents: string[] = [
Expand Down
13 changes: 8 additions & 5 deletions test/fixtures/linter/rules/NoDeprecatedApi/manifest.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,22 +43,25 @@
"minUI5Version": "1.119.0",
"libs": {
"sap.ui.core": {},
"sap.m": {},
"sap.m": {},
"sap.ca.scfld.md": {},
"sap.ca.ui": {},
"sap.dragonfly": {},
"sap.landviz": {},
"sap.fe.common": {},
"sap.fe.plugins": {},
"sap.fe.semantics": {},
"sap.landvisz": {},
"sap.makit": {},
"sap.me": {},
"sap.sac.grid": {},
"sap.ui.commons": {},
"sap.ui.suite": {},
"sap.ui.ux3": {},
"sap.ui.vtm": {},
"sap.uiext.inbox": {},
"sap.webanalytics.core": {},
"sap.zen.dsh": {},
"sap.zen.commons": {},
"sap.zen.crosstab": {}
"sap.zen.crosstab": {},
"sap.zen.dsh": {}
},
"components": {
"sap.zen.dsh.fioriwrapper": {}
Expand Down
58 changes: 41 additions & 17 deletions test/lib/linter/rules/snapshots/NoDeprecatedApi.ts.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -795,7 +795,7 @@ Generated by [AVA](https://avajs.dev).
[
{
coverageInfo: [],
errorCount: 20,
errorCount: 23,
fatalErrorCount: 0,
filePath: 'manifest.json',
messages: [
Expand All @@ -819,102 +819,118 @@ Generated by [AVA](https://avajs.dev).
column: 17,
fatal: undefined,
line: 49,
message: 'Use of deprecated library \'sap.dragonfly\'',
message: 'Use of deprecated library \'sap.fe.common\'',
ruleId: 'ui5-linter-no-deprecated-library',
severity: 2,
},
{
column: 17,
fatal: undefined,
line: 50,
message: 'Use of deprecated library \'sap.landviz\'',
message: 'Use of deprecated library \'sap.fe.plugins\'',
ruleId: 'ui5-linter-no-deprecated-library',
severity: 2,
},
{
column: 17,
fatal: undefined,
line: 51,
message: 'Use of deprecated library \'sap.makit\'',
message: 'Use of deprecated library \'sap.fe.semantics\'',
ruleId: 'ui5-linter-no-deprecated-library',
severity: 2,
},
{
column: 17,
fatal: undefined,
line: 52,
message: 'Use of deprecated library \'sap.me\'',
message: 'Use of deprecated library \'sap.landvisz\'',
ruleId: 'ui5-linter-no-deprecated-library',
severity: 2,
},
{
column: 17,
fatal: undefined,
line: 53,
message: 'Use of deprecated library \'sap.ui.commons\'',
message: 'Use of deprecated library \'sap.makit\'',
ruleId: 'ui5-linter-no-deprecated-library',
severity: 2,
},
{
column: 17,
fatal: undefined,
line: 54,
message: 'Use of deprecated library \'sap.ui.suite\'',
message: 'Use of deprecated library \'sap.me\'',
ruleId: 'ui5-linter-no-deprecated-library',
severity: 2,
},
{
column: 17,
fatal: undefined,
line: 55,
message: 'Use of deprecated library \'sap.ui.ux3\'',
message: 'Use of deprecated library \'sap.sac.grid\'',
ruleId: 'ui5-linter-no-deprecated-library',
severity: 2,
},
{
column: 17,
fatal: undefined,
line: 56,
message: 'Use of deprecated library \'sap.ui.vtm\'',
message: 'Use of deprecated library \'sap.ui.commons\'',
ruleId: 'ui5-linter-no-deprecated-library',
severity: 2,
},
{
column: 17,
fatal: undefined,
line: 57,
message: 'Use of deprecated library \'sap.uiext.inbox\'',
message: 'Use of deprecated library \'sap.ui.suite\'',
ruleId: 'ui5-linter-no-deprecated-library',
severity: 2,
},
{
column: 17,
fatal: undefined,
line: 58,
message: 'Use of deprecated library \'sap.webanalytics.core\'',
message: 'Use of deprecated library \'sap.ui.ux3\'',
ruleId: 'ui5-linter-no-deprecated-library',
severity: 2,
},
{
column: 17,
fatal: undefined,
line: 59,
message: 'Use of deprecated library \'sap.zen.dsh\'',
message: 'Use of deprecated library \'sap.ui.vtm\'',
ruleId: 'ui5-linter-no-deprecated-library',
severity: 2,
},
{
column: 17,
fatal: undefined,
line: 60,
message: 'Use of deprecated library \'sap.zen.commons\'',
message: 'Use of deprecated library \'sap.uiext.inbox\'',
ruleId: 'ui5-linter-no-deprecated-library',
severity: 2,
},
{
column: 17,
fatal: undefined,
line: 61,
message: 'Use of deprecated library \'sap.webanalytics.core\'',
ruleId: 'ui5-linter-no-deprecated-library',
severity: 2,
},
{
column: 17,
fatal: undefined,
line: 62,
message: 'Use of deprecated library \'sap.zen.commons\'',
ruleId: 'ui5-linter-no-deprecated-library',
severity: 2,
},
{
column: 17,
fatal: undefined,
line: 63,
message: 'Use of deprecated library \'sap.zen.crosstab\'',
ruleId: 'ui5-linter-no-deprecated-library',
severity: 2,
Expand All @@ -923,38 +939,46 @@ Generated by [AVA](https://avajs.dev).
column: 17,
fatal: undefined,
line: 64,
message: 'Use of deprecated library \'sap.zen.dsh\'',
ruleId: 'ui5-linter-no-deprecated-library',
severity: 2,
},
{
column: 17,
fatal: undefined,
line: 67,
message: 'Use of deprecated component \'sap.zen.dsh.fioriwrapper\'',
ruleId: 'ui5-linter-no-deprecated-component',
severity: 2,
},
{
column: 13,
fatal: undefined,
line: 76,
line: 79,
message: 'Use of deprecated property \'sap.ui5/resources/js\'',
ruleId: 'ui5-linter-no-deprecated-api',
severity: 2,
},
{
column: 21,
fatal: undefined,
line: 89,
line: 92,
message: 'Use of deprecated property \'sap.ui5/models/odata-v4/settings/synchronizationMode\' of sap.ui.model.odata.v4.ODataModel',
ruleId: 'ui5-linter-no-deprecated-api',
severity: 2,
},
{
column: 21,
fatal: undefined,
line: 95,
line: 98,
message: 'Use of deprecated property \'sap.ui5/models/odata-v4-via-dataSource/settings/synchronizationMode\' of sap.ui.model.odata.v4.ODataModel',
ruleId: 'ui5-linter-no-deprecated-api',
severity: 2,
},
{
column: 17,
fatal: undefined,
line: 99,
line: 102,
message: 'Use of deprecated model type \'sap.ui5/models/odata/type="sap.ui.model.odata.ODataModel"\'',
ruleId: 'ui5-linter-no-deprecated-api',
severity: 2,
Expand Down
Binary file modified test/lib/linter/rules/snapshots/NoDeprecatedApi.ts.snap
View file
Binary file not shown.

0 comments on commit d38e356

Please sign in to comment.