Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for Node v18.14.2 #10

Merged
merged 2 commits into from
Mar 13, 2024
Merged

feat: Add support for Node v18.14.2 #10

merged 2 commits into from
Mar 13, 2024

Conversation

matz3
Copy link
Member

@matz3 matz3 commented Mar 12, 2024

No description provided.

d3xter666
d3xter666 reviewed Mar 12, 2024
View reviewed changes
Copy link
Contributor

@d3xter666 d3xter666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me it seems ok. I was just wondering whether it’s worth it also to adjust the GH workflows to support that scenario until we remove it

@matz3
Copy link
Member Author

matz3 commented Mar 12, 2024

To me it seems ok. I was just wondering whether it’s worth it also to adjust the GH workflows to support that scenario until we remove it

Good point. I've adjusted the version.

flovogt
flovogt requested changes Mar 12, 2024
View reviewed changes
package.json Outdated
"node": "^20.11.0 || >=21.2.0",
"npm": ">= 10"
"node": "^18.14.2 || ^20.11.0 || >=21.2.0",
"npm": ">= 9"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we wanna use the provenance statements. we have to use >=9.5.0 https://docs.npmjs.com/generating-provenance-statements#prerequisites

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node 18.14.2 was the first release with npm 9.5.0 support. so we should be fine. But we could be more restrictive here by setting it to >= 9.5.0, right?
https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V18.md#18.14.2

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@flovogt
Copy link
Member

flovogt commented Mar 12, 2024

Please adjust also the "requirement"section in the readme, regarding the minimal versions https://github.com/SAP/ui5-linter?tab=readme-ov-file#requirements

@matz3 matz3 force-pushed the support-node-18 branch from 03504db to e334e1e Compare March 13, 2024 07:18
@matz3 matz3 merged commit ffeb7d6 into main Mar 13, 2024
5 checks passed
@matz3 matz3 deleted the support-node-18 branch March 13, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d3xter666 d3xter666 d3xter666 left review comments

@flovogt flovogt flovogt approved these changes

@RandomByte RandomByte Awaiting requested review from RandomByte

@maxreichmann maxreichmann Awaiting requested review from maxreichmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matz3 @flovogt @d3xter666