Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Detect pseudo modules of DataType #112

Merged
merged 24 commits into from
Jun 7, 2024
Merged

feat: Detect pseudo modules of DataType #112

merged 24 commits into from
Jun 7, 2024

Conversation

d3xter666
Copy link
Contributor

JIRA: CPOUI5FOUNDATION-830

@d3xter666 d3xter666 marked this pull request as draft May 10, 2024 07:40
@d3xter666 d3xter666 mentioned this pull request May 10, 2024
Merged
@d3xter666 d3xter666 marked this pull request as ready for review May 13, 2024 13:21
@d3xter666 d3xter666 requested a review from a team May 13, 2024 13:21
@matz3 matz3 requested a review from KlattG May 14, 2024 14:02
KlattG
KlattG suggested changes May 15, 2024
View reviewed changes
resources/overrides/library/sap.gantt.d.ts Outdated Show resolved Hide resolved
resources/overrides/library/sap.gantt.d.ts Outdated Show resolved Hide resolved
resources/overrides/library/sap.gantt.d.ts Show resolved Hide resolved
resources/overrides/library/sap.gantt.d.ts Show resolved Hide resolved
resources/overrides/library/sap.m.d.ts Outdated Show resolved Hide resolved
resources/overrides/library/sap.ui.layout.d.ts Show resolved Hide resolved
resources/overrides/library/sap.ui.layout.d.ts Show resolved Hide resolved
resources/overrides/library/sap.ui.layout.d.ts Show resolved Hide resolved
resources/overrides/library/sap.ui.vtm.d.ts Show resolved Hide resolved
resources/overrides/library/sap.uxap.d.ts Outdated Show resolved Hide resolved
matz3
matz3 reviewed May 22, 2024
View reviewed changes
scripts/metadataProvider/createPseudoModulesInfo.ts Outdated Show resolved Hide resolved
resources/dataTypes.json Outdated Show resolved Hide resolved
@d3xter666 d3xter666 requested review from KlattG and matz3 May 23, 2024 12:33
@d3xter666
Copy link
Contributor Author

d3xter666 commented May 23, 2024 •
edited
Loading

Hi @KlattG ,

Would you please take a look at the messages in src/linter/linterReporting.ts

Now the messages we control are extracted in this place and we'll try to consolidate all the remaining messages in there in the near future.

KlattG
KlattG approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@KlattG KlattG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

matz3
matz3 reviewed May 27, 2024
View reviewed changes
src/linter/linterReporting.ts Outdated Show resolved Hide resolved
src/linter/linterReporting.ts Outdated Show resolved Hide resolved
src/linter/linterReporting.ts Outdated Show resolved Hide resolved
@d3xter666 d3xter666 requested a review from matz3 May 30, 2024 10:48
@RandomByte
Copy link
Member

Requires a rebase to resolve conflicts with #127

RandomByte
RandomByte reviewed Jun 3, 2024
View reviewed changes
Copy link
Member

@RandomByte RandomByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

RandomByte
RandomByte approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@RandomByte RandomByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d3xter666 d3xter666 merged commit dd60374 into main Jun 7, 2024
16 checks passed
@d3xter666 d3xter666 deleted the datatype-usage branch June 7, 2024 08:05
@openui5bot openui5bot mentioned this pull request Jun 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KlattG KlattG KlattG approved these changes

@RandomByte RandomByte RandomByte approved these changes

@matz3 matz3 matz3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@d3xter666 @RandomByte @matz3 @KlattG