generated from SAP/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Detect partially deprecated APIs #286
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@KlattG please only review the texts in file "src/linter/messages.ts": https://github.com/SAP/ui5-linter/pull/286/files#diff-09701c0232493655601b38f00fc2ebafebdf513a2aaf652ef5d440d1ea3ee04d Thanks! |
KlattG
approved these changes
Sep 10, 2024
RandomByte
force-pushed
the
detect-partial-deprecation
branch
from
September 10, 2024 12:09
4f78309
to
1f93042
Compare
matz3
approved these changes
Sep 10, 2024
d3xter666
approved these changes
Sep 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect a set of prominent partially-deprecated API (e.g. deprecation of a single parameter of a method signature):
Generic detection would be better, ideally expressed through the generation of the respective TypeScript type definitions. However, that would first require changes in the UI5 JSDoc plugin in order to allow developers to properly express deprecated parameters. Discussions on this are ongoing. For the time being this is a simple solution to detect widely used deprecated parameters.
JIRA: CPOUI5FOUNDATION-788