Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Detect partially deprecated APIs #286

Merged
merged 12 commits into from
Sep 12, 2024
Merged

Conversation

RandomByte
Copy link
Member

@RandomByte RandomByte commented Sep 9, 2024

Detect a set of prominent partially-deprecated API (e.g. deprecation of a single parameter of a method signature):

Generic detection would be better, ideally expressed through the generation of the respective TypeScript type definitions. However, that would first require changes in the UI5 JSDoc plugin in order to allow developers to properly express deprecated parameters. Discussions on this are ongoing. For the time being this is a simple solution to detect widely used deprecated parameters.

JIRA: CPOUI5FOUNDATION-788

@RandomByte RandomByte requested review from KlattG and a team September 9, 2024 15:21
@RandomByte
Copy link
Member Author

@KlattG please only review the texts in file "src/linter/messages.ts": https://github.com/SAP/ui5-linter/pull/286/files#diff-09701c0232493655601b38f00fc2ebafebdf513a2aaf652ef5d440d1ea3ee04d

Thanks!

@RandomByte RandomByte force-pushed the detect-partial-deprecation branch from 4f78309 to 1f93042 Compare September 10, 2024 12:09
@RandomByte RandomByte merged commit dc66f91 into main Sep 12, 2024
13 checks passed
@RandomByte RandomByte deleted the detect-partial-deprecation branch September 12, 2024 07:48
@openui5bot openui5bot mentioned this pull request Sep 12, 2024
@flovogt flovogt mentioned this pull request Sep 23, 2024
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants