Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NoGlobals): Fix false-positives for ElementAccessExpressions and some built-in globals #308

Merged
merged 1 commit into from
Sep 16, 2024
Merged

fix(NoGlobals): Fix false-positives for ElementAccessExpressions and some built-in globals #308

merged 1 commit into from
Sep 16, 2024
+21 −11

Conversation

RandomByte
Copy link
Member

Resolves #305

@RandomByte RandomByte requested a review from a team September 16, 2024 11:21
codeworrior
codeworrior approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@codeworrior codeworrior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@RandomByte RandomByte merged commit db0a057 into main Sep 16, 2024
13 checks passed
@RandomByte RandomByte deleted the fix-global-detections branch September 16, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeworrior codeworrior codeworrior approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected or inconsistent reports of globals
2 participants
@RandomByte @codeworrior