generated from SAP/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Analyze sap.ui.core.Lib.init() call #33
Merged
Merged
+277
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3xter666
force-pushed
the
lib-init-settings
branch
from
March 14, 2024 14:42
399a320
to
40e878e
Compare
d3xter666
force-pushed
the
lib-init-settings
branch
from
March 18, 2024 09:21
2483808
to
3460b11
Compare
matz3
reviewed
Mar 18, 2024
d3xter666
force-pushed
the
lib-init-settings
branch
2 times, most recently
from
March 21, 2024 07:17
8226873
to
9838c34
Compare
Co-authored-by: Matthias Oßwald <[email protected]>
Co-authored-by: Matthias Oßwald <[email protected]>
d3xter666
force-pushed
the
lib-init-settings
branch
from
March 22, 2024 09:10
2595faa
to
93af766
Compare
matz3
reviewed
Mar 22, 2024
RandomByte
requested changes
Mar 22, 2024
Co-authored-by: Merlin Beutlberger <[email protected]>
Co-authored-by: Merlin Beutlberger <[email protected]>
d3xter666
force-pushed
the
lib-init-settings
branch
from
March 22, 2024 14:51
8431092
to
da59f34
Compare
matz3
reviewed
Mar 25, 2024
matz3
reviewed
Mar 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
RandomByte
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: CPOUI5FOUNDATION-793
Adds checks whether
Lib.init()
has been called withapiVersion: 2
property.