Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Detect deprecated themes set by Theming.setTheme() API #389

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

maxreichmann
Copy link
Member

JIRA: CPOUI5FOUNDATION-844

@maxreichmann maxreichmann requested a review from a team October 29, 2024 19:32
@maxreichmann maxreichmann changed the title feat: Detect deprecated themes with Theming.setTheme() API feat: Detect deprecated themes set by Theming.setTheme() API Oct 29, 2024
Copy link
Contributor

@d3xter666 d3xter666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d3xter666 d3xter666 requested a review from a team October 30, 2024 07:03
@maxreichmann maxreichmann merged commit 83b295f into main Oct 31, 2024
13 checks passed
@maxreichmann maxreichmann deleted the js-enhance-detection-deprecated-theming-setTheme branch October 31, 2024 08:51
@openui5bot openui5bot mentioned this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants