feat(cli)!: In case of errors, exit with code 1 #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flovogt
approved these changes
Mar 20, 2024
RandomByte
force-pushed
the
align-exit-code
branch
from
f395f78 to
c03a21c
Compare
True, done |
RandomByte
changed the title
|
Please add also the jira item id CPOUI5FOUNDATION-823 to the commit message |
This change alignes UI5 linter with ESLint (see [1]):
* No errors, maybe warnings: Use exit code 0
* At least one error: Use exit code 1
* Unexpected error (typically caused by an exception): Use exit code 2
BREAKING CHANGE: Depending on how UI5 linter is being used, this change
might change the behavior of that particular scenario. For example a
build script might abort further processing, if any linting errors
are detected.
To ignore exit code 1, for example in a bash script, you may use a
construct like this:
```sh
ui5lint && RC=$? || RC=$?
if [[ "$RC" = 2 ]]; then
exit 1
fi
```
JIRA: CPOUI5FOUNDATION-823
[1]: https://eslint.org/docs/latest/use/command-line-interface#exit-codes
RandomByte
force-pushed
the
align-exit-code
branch
from
c03a21c to
65ea942
Compare
Done 👍 |
flovogt
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change alignes UI5 linter with ESLint (see 1):
BREAKING CHANGE: Depending on how UI5 linter is being used, this change
might change the behavior of that particular scenario. For example a
build script might abort further processing, if any linting errors
are detected.
To ignore exit code 1, for example in a bash script, you may use a
construct like this:
JIRA: CPOUI5FOUNDATION-823