feat: Add type support for "byId" in controllers #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3xter666
reviewed
Nov 25, 2024
This feature adds type definitions for `byId` within controllers so that the usage of deprecated functionality can be detected when controls or elements from the view are accessed by their ID. Previously, only the base element class was known, which is still the case as a fallback. JIRA: CPOUI5FOUNDATION-843
matz3
force-pushed
the
support-controller-byId
branch
from
2eba796 to
d4ca693
Compare
matz3
changed the title
RandomByte
reviewed
Nov 25, 2024
RandomByte
approved these changes
Nov 25, 2024
Merged
matz3
added a commit
that referenced
this pull request
Nov 27, 2024
This solves an issue where the linter would falsely report access to global variables in controller code when accessing the controller class (e.g. by adding methods to the prototype). The issue was caused by the introduction of type support for "byId" in controllers and only appears when there is a view that references the controller. Caused by: #423
matz3
added a commit
that referenced
this pull request
Nov 28, 2024
This solves an issue where the linter would falsely report access to global variables in controller code when accessing the controller class (e.g. by adding methods to the prototype). The issue was caused by the introduction of type support for "byId" in controllers and only appears when there is a view that references the controller. Caused by: #423
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature adds type definitions for
byIdwithin controllers so thatthe usage of deprecated functionality can be detected when controls or
elements from the view are accessed by their ID.
Previously, only the base element class was known, which is still the
case as a fallback.
JIRA: CPOUI5FOUNDATION-843