Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Alerts for new ui5lint version in console #57

Merged
merged 7 commits into from
Apr 9, 2024
Merged

Conversation

d3xter666
Copy link
Contributor

This PR enables notifications in the console when there is a new version of the ui5linter.

@d3xter666 d3xter666 requested a review from a team March 29, 2024 08:18
@d3xter666
Copy link
Contributor Author

The build is failing because of missing coverage for the newly introduced code of the notifier: https://github.com/SAP/ui5-linter/pull/57/files#diff-fa8d4e24d8399e8350f1c8bad05df53e8032ea995835bf911507015e2db61cddR25

However, it's clear that this is untestable code in terms of unit testing. In ui5-tooling/cli this is covered by the integration tests which we're unable to do here (for now), because of the transpilation step.

Adding istanbul ignore * solves the issue, but for higher Node versions, for 18.14.2, that is used for our testing environment it's not taken into account.

I'm wondering what is the possible solution here (apart from lowering the coverage thresholds for that test)?

.nycrc Outdated Show resolved Hide resolved
@matz3
Copy link
Member

matz3 commented Apr 2, 2024

The PR title is a little confusing to me. This does not "enable" a version in the console. It shows a hint in case a new version exists. The user still has to install it.

@d3xter666 d3xter666 changed the title feat: Enable new ui5lint version in console feat: Alerts for new ui5lint version in console Apr 3, 2024
RandomByte
RandomByte previously approved these changes Apr 8, 2024
Copy link
Member

@RandomByte RandomByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with ignoring the coverage decrease for now until we have integration tests.

When rebasing, be aware that we renamed npm-shrinkwrap.json to package-lock.json on main in order to debug a dependabot issue. Also see: #67

@d3xter666 d3xter666 merged commit 9b17887 into main Apr 9, 2024
16 checks passed
@d3xter666 d3xter666 deleted the update-notifier branch April 9, 2024 13:15
@openui5bot openui5bot mentioned this pull request Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants