-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Alerts for new ui5lint version in console #57
Conversation
The build is failing because of missing coverage for the newly introduced code of the notifier: https://github.com/SAP/ui5-linter/pull/57/files#diff-fa8d4e24d8399e8350f1c8bad05df53e8032ea995835bf911507015e2db61cddR25 However, it's clear that this is untestable code in terms of unit testing. In Adding I'm wondering what is the possible solution here (apart from lowering the coverage thresholds for that test)? |
The PR title is a little confusing to me. This does not "enable" a version in the console. It shows a hint in case a new version exists. The user still has to install it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with ignoring the coverage decrease for now until we have integration tests.
When rebasing, be aware that we renamed npm-shrinkwrap.json to package-lock.json on main in order to debug a dependabot issue. Also see: #67
6c8e261
to
b673bdf
Compare
This PR enables notifications in the console when there is a new version of the ui5linter.