Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable links in VS Code terminal #6

Merged
merged 6 commits into from
Mar 13, 2024
Merged

feat: Enable links in VS Code terminal #6

merged 6 commits into from
Mar 13, 2024

Conversation

d3xter666
Copy link
Contributor

@d3xter666 d3xter666 commented Mar 12, 2024

JIRA: CPOUI5FOUNDATION-820

We want to be able to click on the lint text and be able to open the destination file and point to the exact row:column where the linter found an issue.

@d3xter666 d3xter666 changed the title feat(ui5-linter): Enable links in VSCode terminal feat: Enable links in VS Code terminal Mar 13, 2024
RandomByte
RandomByte previously approved these changes Mar 13, 2024
Copy link
Member

@RandomByte RandomByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d3xter666 d3xter666 merged commit 1572f77 into main Mar 13, 2024
5 checks passed
@d3xter666 d3xter666 deleted the vscode-terminal branch March 13, 2024 10:30
This was referenced Mar 13, 2024
RandomByte added a commit to marianfoo/ui5-linter that referenced this pull request Aug 21, 2024
Grouping by rules has been removed with
SAP#6 but it was missed to remove the
corresponding data structures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants