Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Respect src attribute for script tags and include module type for checks #70

Merged
merged 5 commits into from
Apr 12, 2024

Conversation

d3xter666
Copy link
Contributor

@d3xter666 d3xter666 commented Apr 10, 2024

JIRA: CPOUI5FOUNDATION-826
This change addresses the following comments: #48 (comment)

@d3xter666 d3xter666 requested review from matz3 and a team April 10, 2024 07:17
@matz3 matz3 changed the title fix: Respect src sttribute for script tags and include module type for checks fix: Respect src attribute for script tags and include module type for checks Apr 10, 2024
src/linter/html/linter.ts Outdated Show resolved Hide resolved
@d3xter666 d3xter666 requested review from a team and matz3 April 11, 2024 06:51
Copy link
Member

@flovogt flovogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @RandomByte could you have also another look?

src/linter/html/linter.ts Outdated Show resolved Hide resolved
@d3xter666 d3xter666 merged commit 2b28e5f into main Apr 12, 2024
16 checks passed
@d3xter666 d3xter666 deleted the script-tags-fixes branch April 12, 2024 10:07
@openui5bot openui5bot mentioned this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants