Skip to content

Commit

Permalink
Merge pull request sap-linuxlab#882 from marcelmamula/java
Browse files Browse the repository at this point in the history
sap_ha_pacemaker_cluster: JAVA HA scenarios and complete refactor
  • Loading branch information
marcelmamula authored Nov 26, 2024
2 parents 7d30d02 + daae8d6 commit 9b084b8
Show file tree
Hide file tree
Showing 50 changed files with 2,923 additions and 1,451 deletions.
54 changes: 54 additions & 0 deletions roles/sap_ha_pacemaker_cluster/DEPRECATED_VARIABLES.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
# sap_ha_pacemaker_cluster Deprecated input variables

This deprecation of input variables is part of an ongoing effort to improve the codebase by removing unnecessary elements and streamlining the overall design.

These variables fall into a few categories:
- **Obsolete or unused**
- These variables are no longer used and are being removed to reduce technical debt and potential confusion.
- **Renamed**
- These variables are being renamed to better reflect their current purpose and improve code readability.
- This is especially important when the variable's functionality has evolved over time.

## Backwards compatibility
All deprecated variables offer time limited backwards compatibility that will be removed in future.

## List of deprecated input variables
| ~~Old variable~~<br>New variable | Backwards compatible | Reason |
| --------- | --------- | --------- |
| ~~sap_ha_pacemaker_cluster_nwas_abap_sid~~<br>sap_ha_pacemaker_cluster_nwas_sid | :heavy_check_mark: | Removal of `_abap_` |
| ~~sap_ha_pacemaker_cluster_nwas_abap_ascs_instance_nr~~<br>sap_ha_pacemaker_cluster_nwas_ascs_instance_nr | :heavy_check_mark: | Removal of `_abap_` |
| ~~sap_ha_pacemaker_cluster_nwas_abap_ers_instance_nr~~<br>sap_ha_pacemaker_cluster_nwas_ers_instance_nr | :heavy_check_mark: | Removal of `_abap_` |
| ~~sap_ha_pacemaker_cluster_nwas_abap_ascs_sapinstance_instance_name~~<br>sap_ha_pacemaker_cluster_nwas_ascs_sapinstance_instance_name | :heavy_check_mark: | Removal of `_abap_` |
| ~~sap_ha_pacemaker_cluster_nwas_abap_ers_sapinstance_instance_name~~<br>sap_ha_pacemaker_cluster_nwas_ers_sapinstance_instance_name | :heavy_check_mark: | Removal of `_abap_` |
| ~~sap_ha_pacemaker_cluster_nwas_abap_ascs_sapinstance_start_profile_string~~<br>sap_ha_pacemaker_cluster_nwas_ascs_sapinstance_start_profile_string | :heavy_check_mark: | Removal of `_abap_` |
| ~~sap_ha_pacemaker_cluster_nwas_abap_ers_sapinstance_start_profile_string~~<br>sap_ha_pacemaker_cluster_nwas_ers_sapinstance_start_profile_string | :heavy_check_mark: | Removal of `_abap_` |
| ~~sap_ha_pacemaker_cluster_nwas_abap_ascs_filesystem_resource_name~~<br>sap_ha_pacemaker_cluster_nwas_ascs_filesystem_resource_name | :heavy_check_mark: | Removal of `_abap_` |
| ~~sap_ha_pacemaker_cluster_nwas_abap_ascs_sapinstance_resource_name~~<br>sap_ha_pacemaker_cluster_nwas_ascs_sapinstance_resource_name | :heavy_check_mark: | Removal of `_abap_` |
| ~~sap_ha_pacemaker_cluster_nwas_abap_ascs_sapstartsrv_resource_name~~<br>sap_ha_pacemaker_cluster_nwas_ascs_sapstartsrv_resource_name | :heavy_check_mark: | Removal of `_abap_` |
| ~~sap_ha_pacemaker_cluster_nwas_abap_ers_filesystem_resource_name~~<br>sap_ha_pacemaker_cluster_nwas_ers_filesystem_resource_name | :heavy_check_mark: | Removal of `_abap_` |
| ~~sap_ha_pacemaker_cluster_nwas_abap_ers_sapinstance_resource_name~~<br>sap_ha_pacemaker_cluster_nwas_ers_sapinstance_resource_name | :heavy_check_mark: | Removal of `_abap_` |
| ~~sap_ha_pacemaker_cluster_nwas_abap_ers_sapstartsrv_resource_name~~<br>sap_ha_pacemaker_cluster_nwas_ers_sapstartsrv_resource_name | :heavy_check_mark: | Removal of `_abap_` |
| ~~sap_ha_pacemaker_cluster_nwas_abap_ascs_sapinstance_automatic_recover_bool~~<br>sap_ha_pacemaker_cluster_nwas_cs_sapinstance_automatic_recover_bool | :heavy_check_mark: | Removal of `_abap_` |
| ~~sap_ha_pacemaker_cluster_nwas_abap_ascs_sapinstance_resource_stickiness~~<br>sap_ha_pacemaker_cluster_nwas_cs_sapinstance_resource_stickiness | :heavy_check_mark: | Removal of `_abap_` |
| ~~sap_ha_pacemaker_cluster_nwas_abap_ascs_sapinstance_ensa1_migration_threshold~~<br>sap_ha_pacemaker_cluster_nwas_cs_sapinstance_ensa1_migration_threshold | :heavy_check_mark: | Removal of `_abap_` |
| ~~sap_ha_pacemaker_cluster_nwas_abap_ascs_sapinstance_ensa1_failure_timeout~~<br>sap_ha_pacemaker_cluster_nwas_cs_sapinstance_ensa1_failure_timeout | :heavy_check_mark: | Removal of `_abap_` |
| ~~sap_ha_pacemaker_cluster_nwas_abap_ascs_group_stickiness~~<br>sap_ha_pacemaker_cluster_nwas_cs_group_stickiness | :heavy_check_mark: | Removal of `_abap_` |
| ~~sap_ha_pacemaker_cluster_nwas_abap_ascs_ers_ensa1~~<br>sap_ha_pacemaker_cluster_nwas_cs_ensa1 | :heavy_check_mark: | Removal of `_abap_` |
| ~~sap_ha_pacemaker_cluster_nwas_abap_ascs_ers_simple_mount~~<br>sap_ha_pacemaker_cluster_nwas_cs_ers_simple_mount | :heavy_check_mark: | Removal of `_abap_` |
| ~~sap_ha_pacemaker_cluster_vip_nwas_abap_ascs_ip_address~~<br>sap_ha_pacemaker_cluster_vip_nwas_ascs_ip_address | :heavy_check_mark: | Removal of `_abap_` |
| ~~sap_ha_pacemaker_cluster_vip_nwas_abap_ascs_resource_name~~<br>sap_ha_pacemaker_cluster_vip_nwas_ascs_resource_name | :heavy_check_mark: | Removal of `_abap_` |
| ~~sap_ha_pacemaker_cluster_vip_nwas_abap_ers_ip_address~~<br>sap_ha_pacemaker_cluster_vip_nwas_ers_ip_address | :heavy_check_mark: | Removal of `_abap_` |
| ~~sap_ha_pacemaker_cluster_vip_nwas_abap_ers_resource_name~~<br>sap_ha_pacemaker_cluster_vip_nwas_ers_resource_name | :heavy_check_mark: | Removal of `_abap_` |
| ~~sap_ha_pacemaker_cluster_vip_nwas_abap_ascs_resource_group_name~~<br>sap_ha_pacemaker_cluster_vip_nwas_ascs_resource_group_name | :heavy_check_mark: | Removal of `_abap_` |
| ~~sap_ha_pacemaker_cluster_vip_nwas_abap_ers_resource_group_name~~<br>sap_ha_pacemaker_cluster_vip_nwas_ers_resource_group_name | :heavy_check_mark: | Removal of `_abap_` |
| ~~sap_ha_pacemaker_cluster_healthcheck_nwas_abap_ascs_resource_name~~<br>sap_ha_pacemaker_cluster_healthcheck_nwas_ascs_resource_name | :heavy_check_mark: | Removal of `_abap_` |
| ~~sap_ha_pacemaker_cluster_healthcheck_nwas_abap_ers_resource_name~~<br>sap_ha_pacemaker_cluster_healthcheck_nwas_ers_resource_name | :heavy_check_mark: | Removal of `_abap_` |
| ~~sap_ha_pacemaker_cluster_healthcheck_nwas_abap_ascs_id~~<br>sap_ha_pacemaker_cluster_healthcheck_nwas_ascs_id | :heavy_check_mark: | Removal of `_abap_` |
| ~~sap_ha_pacemaker_cluster_healthcheck_nwas_abap_ers_id~~<br>sap_ha_pacemaker_cluster_healthcheck_nwas_ers_id | :heavy_check_mark: | Removal of `_abap_` |
| ~~sap_ha_pacemaker_cluster_storage_nfs_filesytem_type~~<br>sap_ha_pacemaker_cluster_storage_nfs_filesystem_type | :heavy_check_mark: | Typo |


## Status explanation:
- Strikethrough - Name of deprecated variable
- :heavy_check_mark: - Variable is removed from defaults and readme, but still supported.
- :x: - Variable is completely removed and not supported
Loading

0 comments on commit 9b084b8

Please sign in to comment.