Skip to content

Commit

Permalink
Merge pull request #2753 from SCADA-LTS/fix/#2752_Excluding_synchroni…
Browse files Browse the repository at this point in the history
…zed_fields_in_the_toString_implementation

#2752 Excluding synchronized fields in the toString implementation -
  • Loading branch information
Limraj authored Nov 2, 2023
2 parents 2773d0f + 5b5e0fb commit 76b3231
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -223,12 +223,10 @@ public int getPriority() {

@Override
public String toString() {
return "ImageRetriever{" +
"monitor=" + monitor +
", " + (dp == null ? null : LoggingUtils.dataPointInfo(dp.getVO())) +
return "ImageRetriever{dp='" + (dp == null ? null : LoggingUtils.dataPointInfo(dp.getVO())) + '\'' +
", time=" + time +
", retrievalFailure=" + retrievalFailure +
", saveFailure=" + saveFailure +
", retrievalFailure='" + (retrievalFailure == null ? null : retrievalFailure.getLocalizedMessage(Common.getBundle())) + '\'' +
", saveFailure='" + (saveFailure == null ? null : saveFailure.getLocalizedMessage(Common.getBundle())) + '\'' +
'}';
}
@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -666,8 +666,7 @@ public String getDetails() {

@Override
public String toString() {
return "RangeCountHandler{" +
"details='" + details + '\'' +
return "RangeCountHandler{details='" + details + '\'' +
", requestId=" + requestId +
", index=" + index +
", from=" + from +
Expand All @@ -688,8 +687,7 @@ public String getDetails() {

@Override
public String toString() {
return "ConnectionHandler{" +
", version=" + version +
return "ConnectionHandler{version=" + version +
", indexedXids=" + indexedXids +
", details='" + details + '\'' +
", connectionTime=" + connectionTime +
Expand Down
2 changes: 1 addition & 1 deletion src/com/serotonin/mango/rt/maint/work/ProcessWorkItem.java
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ public String toString() {
return "ProcessWorkItem{" +
"command='" + command + '\'' +
", details='" + details + '\'' +
"} " + super.toString();
"}";
}

@Override
Expand Down
4 changes: 1 addition & 3 deletions src/com/serotonin/timer/sync/SingleExecutorSingleWaiter.java
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,7 @@ public int getPriority() {

@Override
public String toString() {
return "TaskWrapper{" +
"command=" + command +
", details='" + details + '\'' +
return "TaskWrapper{details='" + details + '\'' +
'}';
}

Expand Down
3 changes: 1 addition & 2 deletions src/org/scada_lts/mango/service/PointValueService.java
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@
import com.serotonin.util.queue.ObjectQueue;

import static com.serotonin.mango.util.LoggingScriptUtils.infoErrorExecutionScript;
import static com.serotonin.mango.util.LoggingUtils.entryInfo;

/**
* Base on the PointValueDao
Expand Down Expand Up @@ -625,7 +624,7 @@ public int getPriority() {

@Override
public String toString() {
return "BatchWriteBehind{entries size: " + ENTRIES.size() + ", instances size: " + instances.size() + '}';
return "BatchWriteBehind{instances size: " + instances.size() + '}';
}

@Override
Expand Down

0 comments on commit 76b3231

Please sign in to comment.