#2988 Fixed active sessions load in loggedUsers bean when tomcat sta…

…rts: - user sessions initialize first; - check admin;
SCADA-LTS · Aug 21, 2024 · a0e635a · a0e635a
1 parent b06c4a8
commit a0e635a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/src/com/serotonin/mango/MangoContextListener.java b/src/com/serotonin/mango/MangoContextListener.java
@@ -111,6 +111,8 @@ public void contextInitialized(ServletContextEvent evt) {
 	private void initialized(ServletContextEvent evt) {
 		log.info("Scada-LTS context starting at: " + Common.getStartupTime());
 
+		sessionsInitialize(evt);
+
 		scriptContextInitialize();
 
 		// Get a handle on the context.
@@ -198,8 +200,6 @@ private void initialized(ServletContextEvent evt) {
 
 		initSchedule();
 
-		sessionsInitialize(evt);
-
 		log.info("Scada-LTS context started");
 	}
 

diff --git a/src/org/scada_lts/login/LoggedUsers.java b/src/org/scada_lts/login/LoggedUsers.java
@@ -127,7 +127,7 @@ public void loadSessions(Session[] sessions) {
                 if(authentication != null) {
                     String username = authentication.getName();
                     User sessionUser = userService.getUser(username);
-                    if (sessionUser != null) {
+                    if (sessionUser != null && (!sessionUser.isAdmin() || isAdmin(authentication))) {
                         int userId = sessionUser.getId();
                         loggedSessions.putIfAbsent(userId, new ArrayList<>());
                         loggedSessions.get(userId).add(httpSession);
@@ -155,4 +155,13 @@ private static void update(User user, Map<Integer, User> loggedUsers,
         }
         loggedUsers.put(user.getId(), user);
     }
+
+    private static boolean isAdmin(Authentication authentication) {
+        for(GrantedAuthority authority: authentication.getAuthorities()) {
+            if("ROLE_ADMIN".equals(authority.getAuthority())) {
+                return true;
+            }
+        }
+        return false;
+    }
 }