Feature/#2384 added test script in meta data source on new UI #2737
Conversation
In point.vue: - Added validateScript() method - Added 'Run script' button to Meta Data Point editing - Added alert that shows result of working script - Modified script textarea to run validateScript method - Added new rule that is checking if script is correct - Added script.runScript translation key to en.json
- Added correct error message when creating new data point and script field is empty - Added delayed validation, so requests for validation are not send every letter typed - Added handling of error when field for script is empty and you press "run script", now when field is empty and you press "run script" nothing happens - Deleted duplicated property key dox.newUISettings
This reverts commit 032e8e1.
This reverts commit 23d8dbf.
- Added validation in validateScript() method for empty text area of script - Added script validation when focusing out of the script text area - Added script validation when changing data point type so there is no possibility of saving with incorrect script
…Meta_Data_Source_on_new_UI
corrected en.json
- Added validation after adding context datapoint for script - Added validation after editing text fields like data point name, datapoint export ID and description
- Moved error messages to alert component - Added valdiation on removing context datapoint
- Removed validation on focus out for textareas: Data point name, export ID, description
- Added rules validation on load for data point creation form
This reverts commit f448052.
This reverts commit 6b415b3.
This reverts commit 787144a.
This reverts commit 55f59cb.
There was a problem hiding this comment.
Sum up:
Problem 1
Click on 'Create new data point' for Meta Data Source;
Created Data Point with script "return 1;" as dp_1;
Refresh page and edit dp_1;
Added disabled Data Point to Script Context -> This does not trigger validation;
Expected behavior:
Also, a change in the context of the script should validate the script.
Problem 2
Click on 'Create new data point' for Meta Data Source;
Created Data Point with script "return 1;" as dp_1;
Refresh page, and edit Data Point dp_1;
Click on 'Run script' and add disabled Data Point to context, and click update -> Successfully updated script failing validation, as you can see by clicking in the Script field and then outside this field;
Problem 3
Click on 'Create new data point' for Meta Data Source;
Created Data Point with script "return 1;" as dp_1;
Refresh page, and edit Data Point dp_1;
Click on 'Run script' and add disabled Data Point to context, and click update;
Refresh page and edit dp_1;
Click on 'Run script' -> no message with the result of the script
Problem 4
Click on 'Create new data point' for Meta Data Source;
Created Data Point with script "return 1;" as dp_1;
Refresh page, and edit Data Point dp_1 -> The update button is not active, we change the description and it is still greyed out;
Expected behavior:
After changing fields such as description, or other field, the update button should be active;
Problem 5
Click on 'Create new data point' for Meta Data Source;
Created Data Point with script "return 1;" as dp_1;
Refresh page, and edit Data Point dp_1 -> The update button is not active, is greyed -> error
Expected behavior:
As in other forms, the update button should be available after opening the point edit form
Problem 6
Click on 'Create new data point' for Meta Data Source;
Created Data Point with script "return 1;" as dp_1;
Click on 'Cancel' -> The form window does not close and validates the script;
Expected behavior:
Clicking the cancel button should reset the form values and close the form window.
Problem 7
Click on 'Create new data point' for Meta Data Source;
Created Data Points with script "return 1;" as dp_1, and script "return 2;" as dp_2, disabled;
Refresh page, and edit Data Point dp_1;
Added disabled dp_2 to context -> validation stop, inactive update button -> ok
Click on 'Cancel' and edit -> You can update a Meta Data Point even though the context is disabled -> error
Problem 8
Click on 'Create new data point' for Meta Data Source;
Created Data Points with script "return 1;" as dp_1, and script "return 2;" as dp_2, disabled;
Refresh page, and edit Data Point dp_1;
Change script on "return p1.value;" and click active update button -> error
Expected behavior:
After clicking update/create before the request, it has to perform additional validation.
All listed problems have been fixed.
No description provided.