Feature/#2664 added xid validation for event detectors #2743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added maxlength="50" parameter to Export ID (XID) field
- Added maxlength="50" parameter to Export ID (XID) for every event detector - Added 'if' in validate function inside DataPointEditController.java that checks if XID is longer than 50 characters, if it is than saving breaks and notification pops up - Added new key for translations (validate.ped.xidTooLong=XID cannot be longer than 50 characters)
- Added two public static validatesXid methods in XidUtils.java: validateXid(Map<String, String> errors, ResourceBundle resourceBundle, PointEventDetectorVO ped) and validateXid(DwrResponseI18n response, String xid) - Replace code that was using similar validation to methods mentioned above with validateXid method
- Moved xidUnique validation to XidUtils.java - In DataSourceVO.java added error handling, in XidUtils.java validation is using xid contextKey, in DataSourceVO.java used contextKey is dataSourceXid, so displaying errors was added. Tested: - XID handling in publisher, watchlist, datasource edit and datapoint edit views - OK
- Added validateXid method for different needs of form validation
|
Work with:
The topic was about detector validation, so that was fixed. Further fixes:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.