Feature/#2718 mapping path static resources3 #2750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added StaticImagesController, StaticImagesUtils; - Refactoring system/url path; - Added parameters to env.properties: webresource.uploads.path, webresource.graphics.path
…c_Resources3' into feature/#2718_Mapping_path_static_Resources3
Added: - Feature that enables choosing write/read paths for uploaded images and graphics for graphical view for old and new UI inside system settings - Validation for uploads and graphics path (old and new UI) - Methods in utils for accessing uploads and graphics files in dwr, service and utils classes
Limraj
commented
Nov 14, 2023
| } | ||
| }, | ||
| validateForm(paths){ | ||
| const values = paths.map(item => item.value); |
There was a problem hiding this comment.
here you could probably use 'every' instead of 'map'
removal of unnecessary declaration const path = require('path'); corrected translation key, and value; support path with whitespace; refactor MiscSettingsComponent.validateForm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.