Release/2.7.7_old #2778
Closed
Release/2.7.7_old #2778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In point.vue: - Added validateScript() method - Added 'Run script' button to Meta Data Point editing - Added alert that shows result of working script - Modified script textarea to run validateScript method - Added new rule that is checking if script is correct - Added script.runScript translation key to en.json
- Added correct error message when creating new data point and script field is empty - Added delayed validation, so requests for validation are not send every letter typed - Added handling of error when field for script is empty and you press "run script", now when field is empty and you press "run script" nothing happens - Deleted duplicated property key dox.newUISettings
This reverts commit 032e8e1.
This reverts commit 23d8dbf.
- Added validation in validateScript() method for empty text area of script - Added script validation when focusing out of the script text area - Added script validation when changing data point type so there is no possibility of saving with incorrect script
…Meta_Data_Source_on_new_UI
corrected en.json
- Added validation after adding context datapoint for script - Added validation after editing text fields like data point name, datapoint export ID and description
- Moved error messages to alert component - Added valdiation on removing context datapoint
- Removed validation on focus out for textareas: Data point name, export ID, description
- Added rules validation on load for data point creation form
This reverts commit f448052.
This reverts commit 6b415b3.
This reverts commit 787144a.
This reverts commit 55f59cb.
- Added while() which checks if the specified id has already occurred and provides a new one. - Changed removeDatapoint() function, now it checks for key of datapoint.pointLocator.context when deleting context points
- Added initialState variable that stores initial values of datapoint fields - Added for loop that sets the initialState values back to the datapoint variable
- Added maxlength="50" parameter to Export ID (XID) field
- Added maxlength="50" parameter to Export ID (XID) for every event detector - Added 'if' in validate function inside DataPointEditController.java that checks if XID is longer than 50 characters, if it is than saving breaks and notification pops up - Added new key for translations (validate.ped.xidTooLong=XID cannot be longer than 50 characters)
- Added two public static validatesXid methods in XidUtils.java: validateXid(Map<String, String> errors, ResourceBundle resourceBundle, PointEventDetectorVO ped) and validateXid(DwrResponseI18n response, String xid) - Replace code that was using similar validation to methods mentioned above with validateXid method
Moved xid validations to validate() method for each component: - Compound Event - Event Handler - Mailing List - Maintenance Event - Point Link - Scheduled Event
Removed unused imports left from previous commits
…r datapoint #2769 - Added similar duplicate removal system for event text renderers as for text renderers
- Using xid and id instead of getXid() and getId() in validateXid() methods
…n_error_handling #2758 Fixed xid validation error handling
…ange_formats_when_applying_format_from_another_datapoint Fix/ Risk of duplicate range formats when applying format from another datapoint #2769
…operties_Examples Feature/#2815 update point properties examples
…ificationException_in_MonitoredValues #2628 Fixed ConcurrentModificationException in MonitoredValues:
…d point values by id desc if ts is same;
- corrected includeTestsMatching from ImageChartUtilsTestSuite to ImageChartUtilsTestsSuite (build.gradle) - corrected tests, added cases, and renamed: CalculateLinesImageChartUtilsTest, CalculateLinesImageChartUtilsExceptionTest, and corrected tests, added cases for: TruncateStringUtilsExceptionTest, TruncateStringUtilsTest and renamed test: ReplaceMacroStringUtilsTest; - refactoring, corrected method ImageChartUtils.calculateHeightConsolidatedChart, renamed on calculateHeightChart, removed throws IllegalArgumentException, extracted method calculateLinesNumber for calculate only lines number, corrected algorithm; - corrected state: LINE_LENGTH_IN_LEGEND_LIMIT=156, and DATA_POINT_EXTENDED_NAME_LENGTH_LIMIT=54; - renamed state: IMAGE_WIDTH_PIXELS, IMAGE_HEIGHT_PIXELS, POINT_LABEL_HEIGHT_IN_LEGEND_PIXELS, LINE_LENGTH_IN_LEGEND_LIMIT, DATA_POINT_EXTENDED_NAME_LENGTH_LIMIT, POINT_IMAGE_WIDTH_PIXELS, POINT_IMAGE_HEIGHT_PIXELS; - corrected method ReportChartCreator.createContent; - not use deprecated method reportInstancePointDAO.insert; - corrected method StringUtils.truncate;
…space_in_reports_screen2
- corrected test TruncateStringUtilsTest
…ch_space_in_reports_screen2' into fix/#2726_Legend_occupies_too_much_space_in_reports_screen2
…ion_Change_Point_Value_By_User
- removed MangoPointValuesWithChangeOwner from imports in PointValueService; (this import appeared in conflict resolution)
…cted annotation for other source user
- change error on debug logging level in ImageChartUtils.calculateLinesNumber; - separate logic and app cases: CalculateLinesImageChartUtilsAppCaseTest, CalculateLinesImageChartUtilsLogicCaseTest; - added cases to test TruncateStringUtilsExceptionTest
- change error on debug logging level in ImageChartUtils.calculateLinesNumber; - separate logic and app cases: CalculateLinesImageChartUtilsAppCaseTest, CalculateLinesImageChartUtilsLogicCaseTest; - added cases to test TruncateStringUtilsExceptionTest
…een2' of https://github.com/SCADA-LTS/Scada-LTS into fix/#2726_Legend_occupies_too_much_space_in_reports_screen2
- corrected DataPointSynchronizedRT; - corrected PointValueStateUtils.isSetPoint include source: User, PointLinkSetPointSource, RestApiSource; - corrected PointValueCacheTest;
- The currently entered name from the view edit and new form is retained after when clicking the "Upload Image" or "Reset Image" button, what causes changes are made in the background view. - Corrected ViewControllerUtils.getOrEmptyView.
…_after_loading_the_background_file #1075 Reset the view name after loading the background file
…_much_space_in_reports_screen2 #2726 Legend occupies too much space in reports screen
…nnotation_Change_Point_Value_By_User #2798 Corrected History Annotation Change Point Value By User
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.