#2805 Upgrade Node #2990
#2805 Upgrade Node #2990
Conversation
- Nodejs upgraded to v22 LTS - Cypress upgraded
Java Script Mocha Unit Test Results268 tests 268 ✅ 3s ⏱️ Results for commit 1acb691. ♻️ This comment has been updated with latest results. |
Java JUnit Test Results2 517 tests 2 517 ✅ 45s ⏱️ Results for commit 1acb691. ♻️ This comment has been updated with latest results. |
|
Hi @YuaFox, Remember that we have two vue projects, where each time you change the version you have to remove node_modules in places:
Regards, |
- Added router to tests - Updated @vue/test-utils - Updated package-lock.json
scadalts-ui/.gitignore
Outdated
| !@min-gb/dist | ||
| !@min-gb/public | ||
| !@min-gb/src | ||
| !@min-gb/*.* |
There was a problem hiding this comment.
We don't want it in ignore, this library is used in our code, and since it is no longer available in the remote repository we have moved it to sources, what lies ahead is to integrate this library in our sources:
#2957
There was a problem hiding this comment.
I'm aware of that, thats why i put the !, to include it in the repo. I changed it to that to ignore the node_modules folder inside @min-gb
There was a problem hiding this comment.
Hi @YuaFox, 'to include it in the repo'?
I mean what did you do because I don't understand...
If you set ignore on this library, git will not track changes in it, we don't want anything in the sources to be ignored by git.
There was a problem hiding this comment.
Okay, I understand, you made it so that it won't be ignored? Great, we need to audit this library, what is it, etc.
Can't we rewrite the functions of this library ourselves.
There was a problem hiding this comment.
From what I can see, this configuration does not block the visibility of changes in min-gb, so there is no need to change it here, unless I am missing something, I just did a test and changed the file: \node_modules@min-gb\vuejs-components\babel. config.js and git sees this change.
There was a problem hiding this comment.
@YuaFox You just need to make sure whether there were problems with them on node 14 as well. If so, they can be corrected in a separate issue
.
There was a problem hiding this comment.
Hi @YuaFox,
Can you confirm that the tests worked similarly on node 14?
If so, I'll take a look at the code and we'll merge.
It is best to create a new issue to fix these tests.
Regards,
Kamil Jarmusik
There was a problem hiding this comment.
Hi @YuaFox,
you still need to update the files:
- WebContent/resources/package-lock.json,
- scadalts-ui/package-lock.json;
As follows:
- We delete these two lock files;
- Delete:
- WebContent/resources/node_modules,
- scadalts-ui/node_modules (and rollback @min-gb);
- We rebuild the project;
I have these files updated, I can commit it to your branch if you don't mind.
#2805_Upgrade_Node__-_corrected__WebContent_resources_package-lock_json,_scadalts-ui_packa.patch
Regards.
There was a problem hiding this comment.
Hi @Limraj ,
If you have these files changed feel free to to commit them here.
The unit tests work as expected, the cypress tests there are some that worked on node 14 but not on node 22. I haven't had time to take a closer look and see if it's just a change in the dom or something similar or if they are real bugs.
There was a problem hiding this comment.
Hi @YuaFox,
usage command:
npx cypress run
and Node version:
then:
| @@ -82,6 +82,7 @@ export function prepareShallowMountWrapper( | |||
| vuetify, | |||
| store, | |||
| i18n, | |||
| router, | |||
There was a problem hiding this comment.
What is the justification for this?
There was a problem hiding this comment.
If the router is not added to tests, SynopticPanel testing don't work because this.$router is undefined.
https://github.com/SCADA-LTS/Scada-LTS/actions/runs/10505804935/job/29104184414
I dont get how testing was working before upgrading.
scadalts-ui/.gitignore
Outdated
| !@min-gb/dist | ||
| !@min-gb/public | ||
| !@min-gb/src | ||
| !@min-gb/*.* |
There was a problem hiding this comment.
I copied min-gb and called min-gb2 and this pattern worked as we expected: (what has already been added to the git repository does not work with gitignore)
node_modules/*
!node_modules/@min-gb
node_modules/@min-gb/vuejs-components/*
!node_modules/@min-gb/vuejs-components/dist
!node_modules/@min-gb/vuejs-components/src
!node_modules/@min-gb/vuejs-components/public
!node_modules/@min-gb/vuejs-components/*.*
but:
node_modules/*
!@min-gb/dist
!@min-gb/public
!@min-gb/src
!@min-gb/*.*
not working for dir/file that have not been added to the git repository.
You can also add this to the main gitignore file (\Scada-LTS\.gitignore):
WebContent/resources/js-ui/
then only file change from repo:
There was a problem hiding this comment.
Sorry, I didn't notice there was a vuejs-components subfolder
There was a problem hiding this comment.
Hi @YuaFox,
You can also add this to the main gitignore file (\Scada-LTS.gitignore):
WebContent/resources/js-ui/
There was a problem hiding this comment.
@YuaFox,
Okay, but I guess this pattern doesn't work, see for yourself... maybe because at the beginning there is /
There was a problem hiding this comment.
Its working for me doing this command to force retracking of all files.
git rm --cached -r . && git add .
After doing this i have 0 files tracked from WebContent/resources/js-ui/ folder, but i found a problem:
.gitignore says /tomcat/lib should not be tracked but its in the repo
There was a problem hiding this comment.
Hi @YuaFox Ok, it actually works for me, it doesn't show these changes either. (/WebContent/resources/js-ui/)
However, tracking /tomcat/lib is enabled, if it is in the sources, there is not much other option... and I don't see a pattern that could exclude this folder from tracking, there is neither the word lib nor tomcat.
- Removed deprecated cypress functions - Removed modern_watch_list test
- Fixed scadalts-ui .gitignore
- update lock file: scadalts-ui/package-lock.json, WebContent/resources/package-lock.json
- removed ^ form Cypress version, and update package-lock.json files;
- corrected cypress config, added: fixturesFolder, specPattern; - added ag-grid-community lib;
- revert data_point_details.cy.js
- upgrade version Node to v22.9.0;
There was a problem hiding this comment.
There was a problem with the latest version 22.10.0 but rolling back to version 22.9.0 solved the problem. The Node version was set to a fixed version to exclude the possibility that the project would stop building for this reason.
A separate issue has also been created for e2e test fixes.
Upgrade to node v22 LTS and update libraries
This is an experimental pull request