feat: WebClient 예외 핸들링 리팩터링, Timeout 예외 핸들링 추가 (#60) #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- onStatus isError로 변경 - 커스텀 예외가 아닌 예외 핸들링 - Mono.Error로 래핑
Test Results20 files 20 suites 3s ⏱️ Results for commit 4899ca4. |
Laeng
approved these changes
Dec 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
PR 세부 내용
이슈 내용대로 타임아웃 예외 핸들링 기능을 추가했습니다.
지금은 5초로 설정을 해뒀고, 나중에 로그를 확인하여 시간을 조절할 필요가 있을 것 같습니다.
또한, WebClient에 발생하는 중복된 코드(ex) handleConnectError())를 코틀린 확장 함수를 사용하여 제거하였습니다.