feat: ExceptionHandler 로깅 디버그일 때 출력, 각 컴포넌트에서 로깅하도록 변경 (#62) #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results20 files 20 suites 3s ⏱️ Results for commit ba75301. |
Laeng
approved these changes
Dec 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
PR 세부 내용
이슈 내용 그대로,
ExceptionHandler에서GalaxyhubException에 대한 로깅을 debug 레벨에서만 하도록 변경했습니다.이렇게 변경되면
Crawler에서 발생하는 예외가 로깅이 되지 않으므로 따로 로그 처리를 해줘야 했습니다.하지만 Crawler는 추가될 구현체들이 많기 때문에 중복된 로그 코드가 발생할게 분명합니다.
따라서 AOP를 사용하여 Crawler 인터페이스를 구현한 클래스에 예외가 발생하면 로그를 남기도록 하였습니다.