Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: testcontainers 추가 (#16) #72

Merged
merged 2 commits into from
Jan 4, 2024
Merged

feat: testcontainers 추가 (#16) #72

merged 2 commits into from
Jan 4, 2024

Conversation

Laeng
Copy link
Member

@Laeng Laeng commented Jan 3, 2024

관련 이슈

PR 세부 내용

testcontainers를 추가하였습니다. 테스트 실행 전 Docker가 활성화되어 있는지 확인해주세요.

@Laeng Laeng requested a review from seokjin8678 January 3, 2024 12:28
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2024 •
edited
Loading

Test Results

20 files  20 suites   4s ⏱️
66 tests 66 ✅ 0 💤 0 ❌
89 runs  89 ✅ 0 💤 0 ❌

Results for commit 994179c.

♻️ This comment has been updated with latest results.

@seokjin8678 seokjin8678 added 🏢 인프라 인프라에 관한 작업 🧪 테스트 테스트에 관한 작업 labels Jan 3, 2024
seokjin8678
seokjin8678 requested changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@seokjin8678 seokjin8678 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 랭님!
테스트 컨테이너 적용하면 너무 느려지지 않을까 했는데, 생각보다 느리진 않네요. 😂
덤으로 Github Actions에서 도커가 자동으로 실행되는지 깨지지도 않구요.

리뷰에서 남겼지만, 테스트 컨테이너 MySQL 보다, docker-compose를 사용해서 MySQL을 사용해보는 것은 어떨까요?

적용된 설정들은 PR로 남기겠습니다!

build.gradle.kts Show resolved Hide resolved
src/test/resources/application-test.yml Outdated Show resolved Hide resolved
@seokjin8678 seokjin8678 mentioned this pull request Jan 3, 2024
Merged
seokjin8678
seokjin8678 approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@seokjin8678 seokjin8678 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

변경 확인했습니다!

@seokjin8678 seokjin8678 merged commit 1e64e43 into dev Jan 4, 2024
3 checks passed
@seokjin8678 seokjin8678 deleted the feat/#16 branch January 4, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seokjin8678 seokjin8678 seokjin8678 approved these changes

Assignees

@Laeng Laeng

Labels
🧪 테스트 테스트에 관한 작업 🏢 인프라 인프라에 관한 작업
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: testcontainers 를 도입한다.
2 participants
@Laeng @seokjin8678