Skip to content

Commit

Permalink
Linter fixes - revive:unused-parameter, unparam, varcheck and unused (i…
Browse files Browse the repository at this point in the history
…nfluxdata#8984)

* Linter fixes - revive:unused-parameter and unparam

* Linter fixes - revive:unused-parameter and unparam

* Linter fixes - revive:unused-parameter and unparam

* "nolint"'s removed

* Fixes for "varcheck" and "unused" added.

* Fixes for "varcheck" and "unused" added.

* Fixes for "varcheck" and "unused" added.

* Fixes for "varcheck" and "unused" added.

* Fixes for "varcheck" and "unused" added.

* Fixes for "varcheck" and "unused" added.

* Fixes for "varcheck" and "unused" added.

Co-authored-by: Pawel Zak <Pawel Zak>
  • Loading branch information
zak-pawel authored Mar 22, 2021
1 parent 24c8fb2 commit 74a1acd
Show file tree
Hide file tree
Showing 204 changed files with 802 additions and 1,600 deletions.
58 changes: 4 additions & 54 deletions .golangci.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
linters:
disable-all: true
enable:
- bodyclose
- dogsled
Expand All @@ -18,55 +19,6 @@ linters:
- unparam
- unused
- varcheck
disable:
- asciicheck
- deadcode
- depguard
- dupl
- exhaustive
- funlen
- gci
- gochecknoglobals
- gochecknoinits
- gocognit
- goconst
- gocritic
- gocyclo
- godot
- godox
- goerr113
- gofmt
- gofumpt
- goheader
- goimports
- golint
- gomnd
- gomodguard
- gosec
- ifshort
- interfacer
- lll
- makezero
- maligned
- megacheck
- misspell
- nestif
- nlreturn
- noctx
- nolintlint
- paralleltest
- prealloc
- rowserrcheck
- scopelint
- structcheck
- stylecheck
- testpackage
- thelper
- tparallel
- wastedassign
- whitespace
- wrapcheck
- wsl

linters-settings:
revive:
Expand Down Expand Up @@ -131,7 +83,7 @@ linters-settings:

run:
# timeout for analysis, e.g. 30s, 5m, default is 1m
timeout: 5m
timeout: 10m

# which dirs to skip: issues from them won't be reported;
# can use regexp here: generated.*, regexp is applied on full path;
Expand Down Expand Up @@ -169,10 +121,8 @@ issues:
linters:
- govet

# Show only new issues created after git revision `HEAD~`
# Great for CI setups
# It's not practical to fix all existing issues at the moment of integration: much better to not allow issues in new code.
# new-from-rev: "HEAD~"
- path: _test\.go
text: "parameter.*seems to be a control flag, avoid control coupling"

output:
format: tab
Loading

0 comments on commit 74a1acd

Please sign in to comment.