-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major update, courtesy HEAT, LLC #2
Open
EmperorArthur
wants to merge
14
commits into
SCRMHub:master
Choose a base branch
from
EmperorArthur:develop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were already required, but were not in the compoer.json file. Also added a composer.lock file. The composer license did not match the License file, so updated that as well. Added myself as an Author.
Currently this requires editing the javascript, and the server requires it. Some AWS Libraries don't actually use it, and it costs quite a bit of CPU.
EmperorArthur
force-pushed
the
develop
branch
from
September 18, 2019 19:51
3455a21
to
3212d18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
HEAT, LLC is an environmental monitoring company based in Knoxville, TN. They have generously allowed me to upstream my work with your library. This library has been extremely helpful and saved me quite a bit of time, and I did not want my work to drift from what you all are using.
I am sorry for the long list of changes, and can break it up into multiple requests if you would like. This was merely the first time I was given the go ahead to upstream this code.
Major Feature Changes