Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
UtilTests.py
from the top level to theUtil
package directory, for consistency with the other packages with unittests.Renamed
Util/types.py
->Util/sctypes.py
.types
is the name of a stdlib module and it's a bad idea to duplicate it, even though in this case it was "legal" since our file was not at the top level. (MovingUtilTests.py
actually made this a real problem)Class
Selector
is no longer anOrderedDict
, it just inherits from dict as ordering is now preserved and we never used any extra features ofOrderedDict
.Fix API doc build - was missing a good bit of Util since it was split into a package.
Moved the import-loop warning to the top of
__init__.py
so it will be more visible.Fiddly linting, doc-stringing, etc. Super-fiddly: pylint flags
foo
,bar
andbaz
as prohibited variable/function/method names. Actually changed these inUtilTests.py
.SCons.Errors
has been a source of import loops because it importsSCons.Util
. Now Util is split, directly import from theSCons.Util.sctypes
submodule the two thingsErrors
needs - this may reduce the chance of import problems.Contributor Checklist:
CHANGES.txt
(and read theREADME.rst
)