Migrate to FastAPI #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbevers
force-pushed
the
fastapi
branch
9 times, most recently
from
219c378 to
226c9e6
Compare
Pull Request Test Coverage Report for Build 3497366675
💛 - Coveralls |
kbevers
force-pushed
the
fastapi
branch
7 times, most recently
from
a6f43fe to
6dea204
Compare
Apart from a few very minor details the API should be 1:1 comparable with the previous rendition based on flask. The auto-generated docs are improved and now knows about the token parameter required when the API is accessed via dataforsyningen.dk
The existing base image seems to be abandoned and are not seeing updates anymore. This isn't sustainable in the long run and a new base images is implemented. The container is now based on a condaforge image which allows us to use the conda environment used in development.
Pydantic primarily added to have the auto-generated docs include response examples alongside the regular API documentation. Added benefit of Pydantic is that returned data is validated. During development this did indeed uncover problem in data.json, where an entry was missing data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress.