Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update extsubscript #447

Merged
merged 3 commits into from
Jul 1, 2024
Merged

Update extsubscript #447

merged 3 commits into from
Jul 1, 2024

Conversation

enekomartinmartinez
Copy link
Collaborator

Description

  • Allow Vensims GET DIRECT/XLS SUBSCRIPT when lastcell is not a cell value.
  • Allow Vensims GET DIRECT/XLS SUBSCRIPT defined with cell range names.

Related issues

#261 #443

Type of change

  • Bug fix

PR verification (to be filled by reviewers)

  • The code follows the PEP 8 style
  • The new code has been tested properly for all the possible cases
  • The overall coverage has not dropped and other features have not been broken.
  • If new features have been added, they have been properly documented
  • docs/whats_new.rst has been updated
  • PySD version has been updated

@enekomartinmartinez enekomartinmartinez mentioned this pull request Jun 29, 2024
Closed
@enekomartinmartinez enekomartinmartinez changed the base branch from master to dev-external July 1, 2024 10:46
@enekomartinmartinez enekomartinmartinez changed the base branch from dev-external to master July 1, 2024 10:46
@enekomartinmartinez enekomartinmartinez merged commit 3ec6762 into master Jul 1, 2024
15 checks passed
@enekomartinmartinez enekomartinmartinez deleted the update_extsubscript branch July 1, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@enekomartinmartinez