Average Annual CO2 display name has extra characters

[perryr16]

Describe the bug
After running a CO2 analysis an analysis_co2 extra data column is generated. The created display name is: ('Average Annual CO2 (kgCO2e)',)

Expected Behavior

the display name should be Average Annual CO2 (kgCO2e)

Steps to Reproduce

1. import property spreadsheet with meters (ex: ESPM_JCC_Custom_Download_BETTERTest.xlsx)
2. update eGRID Subregion Code (ex: "AZNM"
3. run a CO2 analysis
4. go to Column List Profiles and check "Average Annual CO2"

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity within 60 days. It will be closed if no further activity occurs. Thank you for your contributions.

[RDmitchell]

I would think this issue still needs to be fixed.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity within 60 days. It will be closed if no further activity occurs. Thank you for your contributions.

[RDmitchell]

I will test this to see if it is still an issue, but if no one has worked on it I suspect it is.

[RDmitchell]

Instance: dev1
SHA: 4b87532

This is still an issue

[RDmitchell]

@isalanglois -- because this is still a problem, I moved it into the In Progress column but feel free to put it somewhere else as appropriate. Thx

[isalanglois]

@RDmitchell Does it need to be reassigned?

[RDmitchell]

I verified it is still happening, so I guess it needs to be assigned to someone to work on.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity within 60 days. It will be closed if no further activity occurs. Thank you for your contributions.

[isalanglois]

@RDmitchell any updates on this ticket?

[RDmitchell]

It doesn't seem like anyone has worked on it, so I don't see why it would be fixed.

Do you need me to test it again? I'll put it in the test column, but if it is still a problem I will put it back in the To Do column

[RDmitchell]

Not sure why it was in the "in Progress" column, since I don't think anyone was working on it.

[RDmitchell]

Instance: dev1
SHA: c948690 (2.18.0)

This is still an issue -- no one has worked on it.

Am moving it to the Q3 project. It would be nice to clean this up.

[haneslinger]

Elizabeth fixed this here. However her fix will only apply to column creation going forward, is doesn't go back and correct columns. I can exec into the dbs and fix column name if you want. I just need the instance, org, and column names.

[RDmitchell]

@nllong / @axelstudios -- should @haneslinger fix existing data on the LBNL production instance? Not sure very many orgs (besides my test orgs) have this problem, so it might not be worth the effort.

[RDmitchell]

@haneslinger / @nllong / @axelstudios -- could we not set issues to done until they have been deployed to a dev server and tested by me?

I am going to change the status from Done to Test.

[RDmitchell]

But I need to know whether the fix has been deployed, etc.

[RDmitchell]

@perryr16 -- I assume this has been deployed to dev1, since it is in test.

Instance: dev1
SHA: 9c719a9
Org: LBNL 200
Cycle: CO2 Analysis Testing

None of the data in that cycle had meter data, which is needed for the CO2 analysis.

So I imported meter data for 2 of the records

I then did a CO2 analysis on those 2 records, which was successful for both records

And the results appear in the Detail view for those properties

However, the newly fixed "Average Annual CO2 (kgCO2e)" field doesn't exist in the fields for that record, and only the old field "(;Average Annual CO2 (kgCO2e)',)" exists

I thought maybe I needed to delete the old field before redoing the analysis, and I thought I could do it in Column Settings, which should show all the fields, but the Average CO2 field isn't there.

Maybe I am doing something wrong, but I can't figure out how to get the newly fixed field to appear and be filled with the appropriate data.

Also, it seems like we might want to do some sort of data migration on existing data to fix the old field name?

[RDmitchell]

@perryr16 / @haneslinger -- has this fix been deployed to dev1 for testing?

[RDmitchell]

Instance: dev1
SHA: d5d60ea
Org: LBNL 245

Instance: dev2
SHA: d30082b
Org: LBNL 245

The labels are now correct

[RDmitchell]

instance: dev1
SHA: 3.0.0-beta.0.d60822140
Org: LBNL 245

I am confused about what is being calculated and displayed from the CO2 analysis

Here is a result from an analysis -- it displays results for "Average Annual CO2 (kfCO2e): 30075"

When I click on the Property link (which is the internal DB ID, which it shouldn't be, since the user doesn't know what that means) I see these results

• The "card" shows the same results as the Analyses screen, ie, 30,075 kgC02e for Average Annual CO2
• But the data in the list of fields has "Total GHG Emissions" set to "30.07" without any units. This looks suspiciously like the value for Average Annual C02 with different units, but I don't know if it is (I think it shouldn't be?)
  
• Annual Annual CO2 value is still missing
  

[RDmitchell]

@kflemin -- I assigned this to myself to test, and it looks like it is still broken.

I am adding a "testing question" label to it, but I think it should probably go back to the "To Do" pile. But you should probably do that, rather than me.

[RDmitchell]

Here is another example in that same org showing the same thing

[RDmitchell]

instance: dev1
SHA: 3.0.0-beta.0.d60822140
Org: LBNL Test 200
Cycle: CO2 Analysis Testing
Column List Profile: CO2 testing

In this org, with an old analysis, I am still seeing the old (wrong) field name -- does there need to be a migration or something to change this old field name to the correct field name?

[RDmitchell]

And it shows up in the list view also

[RDmitchell]

See also #3707

[RDmitchell]

instance: dev1
SHA: 77b9e4a
Org: BPS - DC
Cycle: 2023

This appears to be fixed when you do a new CO2 calculation -- in this case, a CO2 calculation had not been performed on any records in this org, as far as I can tell

The fields are properly formed in both the Column List Profile and the Inventory List

There might be issues with records that had previously done a CO2 analysis and have these fields already in their "world", but I will look into that and make another issue if that is the case. So I am closing this one.