Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort cycles by start_date on property insights page #4441

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

kflemin
Copy link
Contributor

@kflemin kflemin commented Dec 8, 2023

associated issue: #4187

before: (sorted alphabetically by name)
Screen Shot 2023-12-08 at 3 53 53 PM

after: (sorted by start_date ascending)

Screen Shot 2023-12-08 at 4 36 47 PM

@kflemin kflemin requested a review from haneslinger December 8, 2023 23:39
Copy link

github-actions bot commented Dec 8, 2023

Label error. Requires at least 1 of: Feature, Bug, Enhancement, Maintenance, Documentation, Performance, Do not publish. Found:

@haneslinger haneslinger added the Enhancement Add this label if functionality was generally improved but not a full feature or maintentance. label Dec 11, 2023
Copy link
Contributor

@haneslinger haneslinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a huge deal, but wouldn't it be easier to simply sort the cycles returned but compliance_metrics/{id}/evaluate in the backend? seed/models/compliance_metrics.py line 121,

          'cycles': list(self.cycles.all().order_by(start).values('id', 'name')),

@kflemin
Copy link
Contributor Author

kflemin commented Dec 11, 2023

@haneslinger so much easier!! i'll change it to that, thanks!

@kflemin kflemin requested a review from haneslinger December 12, 2023 22:33
@kflemin kflemin merged commit 3d334cf into develop Dec 13, 2023
7 checks passed
@kflemin kflemin deleted the insights-cycles-sort branch December 13, 2023 17:13
@axelstudios axelstudios changed the title sort cycles by start_date on property insights page Sort cycles by start_date on property insights page Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Add this label if functionality was generally improved but not a full feature or maintentance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants