Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to Pydantic 2 (superset of Jason's) #1030

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

prescod
Copy link
Contributor

@prescod prescod commented Apr 6, 2024

Obsoletes #1018

@prescod prescod requested a review from a team as a code owner April 6, 2024 00:28
@jstvz jstvz enabled auto-merge April 8, 2024 17:08
@prescod
Copy link
Contributor Author

prescod commented Apr 11, 2024

@jstvz

The current test failure is because CCI is on Pydantic 1 while Snowfakery is on Pydantic 2.

Do you want to:

a) upgrade CCI and Snowfakery to Pydantic 2 in a single coordinated release or

b) support Pydantic 1 and 2 simultaneously in Snowfakery so that they can upgrade in a staggered manner?

@prescod
Copy link
Contributor Author

prescod commented Apr 11, 2024

Obviously b) involves ugly cruft that will need to be removed eventually.

@jstvz
Copy link
Contributor

jstvz commented Apr 22, 2024

@jstvz

The current test failure is because CCI is on Pydantic 1 while Snowfakery is on Pydantic 2.

Do you want to:

a) upgrade CCI and Snowfakery to Pydantic 2 in a single coordinated release or

b) support Pydantic 1 and 2 simultaneously in Snowfakery so that they can upgrade in a staggered manner?

Option (a) is my preference.

@prescod
Copy link
Contributor Author

prescod commented Apr 22, 2024

@jstvz . Okay, ping me when the time comes if there are challenges on the Snowfakery side. It actually doesn’t thave a lot of Pydantic stuff in it and arguably what it does have should move to the CCI repo because it relates to CCI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants