Make failure to close a stream an error, as it would be by default. #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prescod
force-pushed
the
feature/output-stream-cleanups
branch
from
312b9b8 to
8809c60
Compare
prescod
force-pushed
the
feature/output-stream-cleanups
branch
from
8809c60 to
f60cd1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
api.pypreviously had code to swallow errors closing streams (files, database connections, etc.)This might hide errors, so I took it out.
There is a kind of output stream known as a MultiplexOutputStream that allows multiple outputs at once. I ADDED exception handling here, to ensure that we try to close all output streams. Nevertheless, once it is done it throws an exception if any failed.
A couple of tests were also updated.