-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CR090a: Harmonization of ActionStatus and Progress in SX #100
base: integration
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
It seems to me there is a misunderstanding of SIRI processes underliying. |
You are right @gthiesing , we shall not mix Situation Progress State and Publishing Action Status. However, my understanding from @haeckerbaer proposal is to add a real Publishing Action Status, dedicated to the communication to passenger (see https://3.basecamp.com/3256016/buckets/9672657/messages/5836829085 - Public is informed about ongoing normalisation) and related to the specific Publishing Action (not to all consequences of the Situation). |
update incoming as discussed in the basecamp: A boolean SituationIsClosing is introduced on PtSituationElement level that corresponds to ActionIsClosing. We should not correlate the closing value of ProgressEnum with a boolean. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls separate the interpretation of Progress and ActionIsClosing.
Progress is not required for showing the "Closing icon"
See https://3.basecamp.com/3256016/buckets/9672657/vaults/5470139022