Adding taxi mode #115
Closed
Adding taxi mode #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, e.g. a rail-replacement service or a low-occupancy bus route, is serviced by a taxi instead of a bus. It would be useful if the SIRI-data could reflect this so that e.g. a specific icon could be used. The suggested change applies to several SIRI datatypes (ET, VM, PT ++).
Possible issues could be that
VehicleModesEnumerationthat this is a part of is described as "MODEs of transport applicable to timetabled public transport."ContinuousModesEnumerationdescribed as "MODEs of transport applicable to private and non-timetabled transport."With this in mind - is
taxian acceptable name here? Would e.g.schedulableTaxior similar be a better choice?