Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Appearance: use environment object var as display name #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Appearance: use environment object var as display name #15

wants to merge 2 commits into from

Conversation

wyrnat
Copy link

@wyrnat wyrnat commented Dec 11, 2023 •
edited
Loading

untested as the current master version is not working for me

what

  • display human readable names for the Environment combobox

why

  • user is able to set the displayed name without restriction from filesystem naming
  • what was the use of the object variable "name" in Environment anyway? Please correct me if I am wrong, but I could not find the purpose

how

  • load all environments from the env_list and gather "name" from each. gather all names into a list
  • set modified list to GUI object for display
  • catch a missing object variable or a faulty environment. object variable should not be mandatory and faulty environment will be handled when user loads it for usage

closes #14

wenatuhs added a commit that referenced this pull request Dec 12, 2023
@wenatuhs
Merge pull request #15 from YektaY/routine-refactor
64ad9f6 
More work on GUI unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

appearance: display Environment class variable "name" in the Environment Combobox
1 participant
@wyrnat