-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sybenzvi/csv to sql #106
Sybenzvi/csv to sql #106
Conversation
It looks like we need a unit test for this. |
…ence_System into sybenzvi/csv-to-sql
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, I am happy with this version. Database works as expected, I added a temporary fix for the factorial problem mentioned here #100
I updated the poetry dependencies to include sqlalchemy
and tabulate
tabulate
is used when someone requests a
snews_pt write-hb-logs
then it dumps the table on the console (on the server)
One thing that might not be desirable is the precision of the Latencies. SNEWS_Coincidence_System/snews_cs/snews_hb.py Line 129 in 486f316
I converted them to integer seconds because sqlalchemy did not like the timedelta objects. However, we are loosing some precision. We should decide if want to improve that |
This PR addresses issue #98 by doing the following:
sqlalchemy
HB_DELETE_AFTER
Note that the use of
sqlalchemy
allows us to switch to a different DB in the future (e.g., Postgres) if we decide to do that, with only a trivial change to the sqlalchemy engine object.