Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed isAsync params usage for createTopics (#900) #1370

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixed isAsync params usage for createTopics (#900) #1370

wants to merge 3 commits into from

Commits on Jan 3, 2020

  1. Fixed isAsync params usage for createTopics

    @lamweili
    lamweili authored Jan 3, 2020
    Configuration menu
    Copy the full SHA
    5fd3764 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2020

  1. Defaults createTopics' param async=false 

    Async must default to false.
It is dangerous to use async=true for createTopics unless explicitly specified.

For running async calls, the subsequent steps (such as addTopics) will fail as the topics are yet to be created/in the progress of creation.
It is the nature of async to return immediately even before the createTopics is completed.

This fixes the regression from the fix 5fd3764.
    @lamweili
    lamweili committed Jan 4, 2020
    Configuration menu
    Copy the full SHA
    b7b1953 View commit details
    Browse the repository at this point in the history

  2. Reduced risk of collision by using uuid.v4() instead of Date.now() 

    (To be consistent with test.highLevelProducer.js line 24)
    @lamweili
    lamweili committed Jan 4, 2020
    Configuration menu
    Copy the full SHA
    8526b0b View commit details
    Browse the repository at this point in the history